This is a list of all comments for DIALIN-DEN-4344-1.

Review Summary: No summary


----------------------------------------
File: tools/install_to_venv.sh
Revision Comment by Behrouz NematiPour on 26 August 2020, 10:25 
https://devapps.diality.us/cru/DIALIN-DEN-4344-1#c3945

  It has been updated in scripts to "Projects"

  Reply by plucia on 26 August 2020, 10:43
  > Have you checked with Dara on this? I think the VM's are
  > setup with the "~/projects" directory. Systems and V&V both
  > have v4 of those VM's already...

    Reply by Behrouz NematiPour on 26 August 2020, 11:29
    > Yes I told him to update that.
    > Will remind him again.

    Reply by Behrouz NematiPour on 26 August 2020, 11:46
    > Reminded him again and he is aware of it and has plan to do
    > so.
    > We use "Projects" and if meanwhile anyone has a non-updated
    > VM will update the folder name manually for now.

      Reply by plucia on 26 August 2020, 11:49
      > Okay. It's "Projects" now

        Reply by Behrouz NematiPour on 26 August 2020, 11:52
        > RESOLVED.

----------------------------------------
File: dialin/common/__init__.py
Revision Comment by Sean Nash on 21 August 2020, 10:45 
https://devapps.diality.us/cru/DIALIN-DEN-4344-1#c3735

  Why is this empty?

  Reply by plucia on 21 August 2020, 11:39
  > It is so during the import process, the modules in the common
  > directory are found. It's used to mark directories as python
  > package directories. 
  > If you remove it, then python will no longer find submodules.
  > 
  > https://docs.python.org/3/reference/import.html#regular-packages
  > 
  > If we add the following to __init__.py then the user doesn't
  > have to know the exact file location of a particular class:
  > 
  > So in dialin.__init__.py, we could add:
  > from hd.hemodialysis_device.py import HD
  > 
  > Then, a dialin script could do:
  > {code}
  > from dialin import HD
  > {code}
  > instead of
  > {code}
  > from dialin.hd.hemodialysis_device import HD
  > {code}
  > 
  > It abstracts away the file location so if we can rename files
  > without the API user being affected.
  > 
  > Your comment reminded me that we weren't doing this yet and
  > so I've added those changes to this review.

    Reply by Sean Nash on 25 August 2020, 11:09
    > RESOLVED

----------------------------------------
File: dialin/common/alarm_defs.py
Revision Comment by Behrouz NematiPour on 26 August 2020, 10:32 
https://devapps.diality.us/cru/DIALIN-DEN-4344-1#c3946

  Is there a way to get these values right from c code of
  firmware?
  Like a scripts which reads the c file and generates this py
  code.

  Reply by plucia on 26 August 2020, 10:36
  > I had the same thought awhile ago and begin investigating it.
  > It may be possible - but will take some time. I previously
  > created a Jira ticket to make sure we implement this feature
  > in the future: [http://dvm-linux02:8080/browse/DIAL-23].

    Reply by Behrouz NematiPour on 26 August 2020, 11:28
    > Great,
    > RESOLVED

----------------------------------------
File: dialin/common/msg_defs.py
Revision Comment by Behrouz NematiPour on 26 August 2020, 10:33 
https://devapps.diality.us/cru/DIALIN-DEN-4344-1#c3948

  Is there a way to get these values right from c code of
  firmware?
  Like a scripts which reads the c file and generates this py
  code.

  Reply by plucia on 26 August 2020, 10:41
  > I had the same thought awhile ago and begin investigating it.
  > It may be possible - but will take some time. I previously
  > created a Jira ticket to make sure we implement this feature
  > in the future: http://dvm-linux02:8080/browse/DIAL-23.

    Reply by Behrouz NematiPour on 26 August 2020, 11:28
    > great,
    > RESOLVED


---

ID: DIALIN-DEN-4344-1 https://devapps.diality.us/cru/DIALIN-DEN-4344-1

Title: DIALIN-DEN-4344_Sprint 25
Statement of Objectives:


State: Closed

Summary: 

Author: plucia
Moderator: plucia
Reviewers: (0 active, 2 completed*)
     Sean Nash   (*)
     Behrouz NematiPour   (*)