DIALIN-DEN-4438-1 DIALIN-DEN-4438_Saline Bolus

closed on 28 Aug 20

Author

Reviewers

DIALIN-DEN-4438_Saline Bolus

Activity

Details
Objectives
General Comments 11
Unresolved
Resolved
Number of files included: 54

dialin 0
- Folder dialin 0
  - Folder dg 0
    - File conductivity_sensors.py 0 Remove
    - File dialysate_generator.py 0 Remove
    - File drain_pump.py 0 Remove
    - File hd_proxy.py 0 Remove
    - File heaters.py 0 Remove
    - File load_cells.py 0 Remove
    - File pressures.py 0 Remove
    - File reservoirs.py 0 Remove
    - File ro_pump.py 0 Remove
    - File temperature_sensors.py 0 Remove
    - File valves.py 0 Remove
  - Folder hd 0
    - File alarms.py 0 Remove
    - File blood_flow.py 0 Remove
    - File buttons.py 0 Remove
    - File dialysate_inlet_flow.py 0 Remove
    - File dialysate_outlet_flow.py 0 Remove
    - File hemodialysis_device.py 0 Remove
    - File pressure_occlusion.py 0 Remove
    - File rtc.py 0 Remove
    - File treatment.py 0 Remove
    - File ui_proxy.py 0 Remove
    - File watchdog.py 0 Remove
  - Folder protocols 0
    - File CAN.py 0 Remove
  - Folder squish 0
    - File denaliMessages.py 0 Remove
    - File messageBuilder.py 0 Remove
    - File unittests.py 3 Remove
  - Folder utils 0
    - File base.py 0 Remove
  - File version.py 0 Remove
- Folder tests 0
  - Folder coverage 0
    - File run_coverage.py 3 Remove
  - Folder unit_tests 0
    - File test_dg_valves.py 0 Remove
    - File test_ui_proxy.py 0 Remove
  - File can_xmit_test.py 0 Remove
  - File dg_test_script.py 0 Remove
  - File dg_valves_test.py 0 Remove
  - File dg_valves_test_observer.py 0 Remove
  - File hd_test_script.py 0 Remove
  - File test_can_xmit.py 0 Remove
  - File test_demo.py 0 Remove
  - File test_dg.py 0 Remove
  - File test_dg_valves.py 0 Remove
  - File test_dg_valves_observer.py 0 Remove
  - File test_hd.py 0 Remove
  - File test_logging.py 0 Remove
  - File test_uf.py 0 Remove
  - File uf_test.py 0 Remove
  - File unit_tests.py 0 Remove
- Folder tools 0
  - File bring_can_interface_down.sh 0 Remove
  - File run_unit_tests.sh 0 Remove
  - File setup_canbus.sh 0 Remove
  - File setup_virtual_can.sh 0 Remove
- File .gitignore 0 Remove
- File CHANGELOG.md 0 Remove
- File README.md 0 Remove
- File changelog.md 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Behrouz NematiPour	Author	1h 11m	7	RESOLVED
plucia (deleted user)	Reviewer - Complete	37m	3	RESOLVED
pmontazemi (deleted user)	Reviewer - Complete	48m	7	OK.
Total		2h 37m	17

Linked issues
- DEN-4438

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Behrouz NematiPour

As a general comment, the only folder which has to be modified if required fo...

As a general comment, the only folder which has to be modified if required for any feature related to a UI Story has to be only dialin/squish/ folder and none of the other files are related to this Story.
The only one comment related to this story has been addressed.
This comment checked as "Needs resolution" so we all see and agree on this topic after it has been resolved.

23 Aug 20

Behrouz NematiPour

Resolved

28 Aug 20

pmontazemi (deleted user)

OK.

28 Aug 20

Behrouz NematiPour

RESOLVED

28 Aug 20

plucia (deleted user)

Can you remove unrelated changesets from this code review? I'm seeing many of...

Can you remove unrelated changesets from this code review? I'm seeing many of my changes in this review

25 Aug 20

plucia

(deleted user)

Resolved

27 Aug 20

plucia (deleted user)

RESOLVED

27 Aug 20

Behrouz NematiPour

I tried to remove it but seems like Jira doesn't listen. sadly after we discu...

I tried to remove it but seems like Jira doesn't listen.
sadly after we discussed in a conversation we had that Sarina arranged, when you told me to merge the staging branch into my working branch I didn't envision at that moment Jira doesn't let us remove it after it has been added.
Fortunately what we currently can do is to only review files in dialin/squish folder.

Thanks,

25 Aug 20

Behrouz NematiPour

Resolved

28 Aug 20

pmontazemi (deleted user)

OK.

28 Aug 20

Behrouz NematiPour

RESOLVED

28 Aug 20

Behrouz NematiPour

[~pmontazemi] Could you please review your comments and if it's not in the di...

[~pmontazemi] Could you please review your comments and if it's not in the dialin/squish please keep it for later/related code reviews?
Thanks,

25 Aug 20

Behrouz NematiPour

Resolved

28 Aug 20

pmontazemi (deleted user)

OK.

28 Aug 20

Behrouz NematiPour

RESOLVED

28 Aug 20

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

DIALIN-DEN-4438-1

DIALIN-DEN-4438_Saline Bolus

DIALIN-DEN-4438-1 17

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Behrouz NematiPour

pmontazemi (deleted user)

Behrouz NematiPour

plucia (deleted user)

plucia (deleted user)

Behrouz NematiPour

pmontazemi (deleted user)

Behrouz NematiPour

Behrouz NematiPour

pmontazemi (deleted user)

Behrouz NematiPour

Log time

DIALIN-DEN-4438_Saline Bolus

DIALIN-DEN-4438-1 17

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Behrouz NematiPour

pmontazemi (deleted user)

Behrouz NematiPour

plucia (deleted user)

plucia (deleted user)

Behrouz NematiPour

pmontazemi (deleted user)

Behrouz NematiPour

Behrouz NematiPour

pmontazemi (deleted user)

Behrouz NematiPour

Log time