This is a list of all comments for DIALIN-DEN-4438-1.

Review Summary: No summary

General Comment by Behrouz NematiPour on 23 August 2020, 12:37 
https://devapps.diality.us/cru/DIALIN-DEN-4438-1#c3786

  As a general comment, the only folder which has to be modified
  if required for any feature related to a UI Story has to be
  only dialin/squish/ folder and none of the other files are
  related to this Story.
  The only one comment related to this story has been addressed.
  This comment checked as "Needs resolution" so we all see and
  agree on this topic after it has been resolved.

  Reply by pmontazemi on 28 August 2020, 16:47
  > OK.

    Reply by Behrouz NematiPour on 28 August 2020, 16:54
    > RESOLVED

General Comment by plucia on 25 August 2020, 11:31 
https://devapps.diality.us/cru/DIALIN-DEN-4438-1#c3888

  Can you remove unrelated changesets from this code review? I'm
  seeing many of my changes in this review

  Reply by plucia on 27 August 2020, 12:36
  > RESOLVED

General Comment by Behrouz NematiPour on 25 August 2020, 13:28 
https://devapps.diality.us/cru/DIALIN-DEN-4438-1#c3907

  I tried to remove it but seems like Jira doesn't listen.
  sadly after we discussed in a conversation we had that Sarina
  arranged, when you told me to merge the staging branch into my
  working branch I didn't envision at that moment Jira doesn't
  let us remove it after it has been added.
  Fortunately what we currently can do is to only review files in
  dialin/squish folder.
  
  Thanks,

  Reply by pmontazemi on 28 August 2020, 16:46
  > OK.

    Reply by Behrouz NematiPour on 28 August 2020, 16:53
    > RESOLVED

General Comment by Behrouz NematiPour on 25 August 2020, 13:34 
https://devapps.diality.us/cru/DIALIN-DEN-4438-1#c3908

  [~pmontazemi] Could you please review your comments and if it's
  not in the dialin/squish please keep it for later/related code
  reviews?
  Thanks,

  Reply by pmontazemi on 28 August 2020, 16:46
  > OK.

    Reply by Behrouz NematiPour on 28 August 2020, 16:52
    > RESOLVED


----------------------------------------
File: dialin/squish/unittests.py
Revision Comment by pmontazemi on 20 August 2020, 21:48 
https://devapps.diality.us/cru/DIALIN-DEN-4438-1#c3695

  Remove extra line.

  Reply by Behrouz NematiPour on 23 August 2020, 12:02
  > I have a screen capture that I can't attach here and put in
  > X:\Users\PemanM.
  > As I explained in the image file, I don't quit understand how
  > Squish is managing the last line.
  > Now I removed extra it shows no empty line at the EOF but I
  > see there is one, prior to that it was showing one but was
  > actually two.
  > Squish and Jira have different view.
  > external editor is showing one empty line though.

    Reply by pmontazemi on 25 August 2020, 09:53
    > RESOLVED.

----------------------------------------
File: tests/coverage/run_coverage.py
Revision Comment by pmontazemi on 20 August 2020, 21:52 
https://devapps.diality.us/cru/DIALIN-DEN-4438-1#c3698

  Why file is empty?

  Reply by plucia on 21 August 2020, 12:41
  > Peman this isn't Behrouz's change. I must have added this as
  > a placeholder. I have now removed it on my development
  > branch, so it can be replaced in the future with the coverage
  > test.

    Reply by pmontazemi on 25 August 2020, 09:54
    > RESOLVED.


---

ID: DIALIN-DEN-4438-1 https://devapps.diality.us/cru/DIALIN-DEN-4438-1

Title: DIALIN-DEN-4438_Saline Bolus
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Reviewers: (0 active, 2 completed*)
     plucia   (*)
     pmontazemi   (*)