This is a list of all comments for DIALIN-DEN-4691-1.

Review Summary: No summary


----------------------------------------
File: dialin/squish/denaliMessages.py
Revision Comment by plucia on 11 November 2020, 10:48 
https://devapps.diality.us/cru/DIALIN-DEN-4691-1#c6110

  To keep dialin consistent, for all new functions please make
  them snake_case instead of camelCase. Also please remove the v
  prefix as this is not used anywhere else in dialin

  Reply by Behrouz NematiPour on 18 November 2020, 19:27
  > It's an effort that can be done later when we transitioning
  > all the APIs to use the CANMessageHandler.
  > All the currently defined API methods are using the same
  > camelCase naming.
  > it needs also to change all the test suits we already have.
  > So I don't think that's what we need to address as part of
  > this code review.

    Reply by plucia on 19 November 2020, 10:05
    > RESOLVED.
    > OK, I will rename these two. For new functions in the
    > future please keep them consistent with the other dialin
    > codebase and PEP8.

----------------------------------------
File: dialin/squish/utils.py
Revision Comment by pmontazemi on 09 November 2020, 09:53 
https://devapps.diality.us/cru/DIALIN-DEN-4691-1#c5927

  milliliter in one word

  Reply by Behrouz NematiPour on 10 November 2020, 14:29
  > done

    Reply by pmontazemi on 10 November 2020, 18:35
    > RESOLVED.

Revision Comment by pmontazemi on 09 November 2020, 09:53 
https://devapps.diality.us/cru/DIALIN-DEN-4691-1#c5928

  milliliter in one word

  Reply by Behrouz NematiPour on 10 November 2020, 14:29
  > done

    Reply by pmontazemi on 10 November 2020, 18:35
    > RESOLVED.


---

ID: DIALIN-DEN-4691-1 https://devapps.diality.us/cru/DIALIN-DEN-4691-1

Title: DIALIN-DEN-4691_Inline Blood Pressure Adjustments
Statement of Objectives:
Refer to the :
 - DEN-4691: UI Blood In-Line Pressure Adjustments
 - http://192.168.10.132:8060/cru/UI-DEN-4691-1

State: Closed

Summary: 

Author: Behrouz NematiPour
Reviewers: (0 active, 2 completed*)
     plucia   (*)
     pmontazemi   (*)