This is a list of all comments for DIALIN-DEN-4856-1.

Review Summary: No summary


----------------------------------------
File: dialin/common/msg_defs.py
Revision Comment by qnguyen on 12 October 2020, 09:13 
https://devapps.diality.us/cru/DIALIN-DEN-4856-1#c5428

  should we keep the copyright?

  Reply by plucia on 14 October 2020, 15:57
  > Yes, if it's already there no reason to remove it. I've added
  > it back

    Reply by qnguyen on 14 October 2020, 16:22
    > RESOLVED.

----------------------------------------
File: dialin/dg/hd_proxy.py
Revision Comment by qnguyen on 12 October 2020, 09:16 
https://devapps.diality.us/cru/DIALIN-DEN-4856-1#c5429

  The file should be renamed to match this.

  Reply by plucia on 14 October 2020, 15:57
  > Done

    Reply by qnguyen on 14 October 2020, 16:22
    > RESOLVED.

----------------------------------------
File: dialin/hd/hemodialysis_device.py
Revision Comment by qnguyen on 12 October 2020, 09:18 
https://devapps.diality.us/cru/DIALIN-DEN-4856-1#c5430

  This message id is not being used.

  Reply by plucia on 14 October 2020, 15:59
  > The version of crucible we're using has an issue where
  > duplicate files show in the file viewer on the left.
  > 
  > If you look at the more recent hemodialysis_device.py file
  > (see the files viewer on the left), this message id is
  > removed:
  > [http://dvm-linux02:8060/cru/DIALIN-DEN-4856-1#CFR-19219]
  > 
  > It is also removed from both msg_defs.py:
  > [http://dvm-linux02:8060/cru/DIALIN-DEN-4856-1#CFR-19027] and
  > [http://dvm-linux02:8060/cru/DIALIN-DEN-4856-1#CFR-19203]

    Reply by qnguyen on 14 October 2020, 17:26
    > RESOLVED.


---

ID: DIALIN-DEN-4856-1 https://devapps.diality.us/cru/DIALIN-DEN-4856-1

Title: DIALIN-DEN-4856_Sprint_27
Statement of Objectives:


State: Closed

Summary: 

Author: plucia
Moderator: plucia
Reviewers: (0 active, 2 completed*)
     qnguyen   (*)
     Sean Nash   (*)