This is a list of all comments for DIALIN-DEN-5053-1.

Review Summary: No summary


----------------------------------------
File: dialin/hd/air_trap.py
Revision Comment by qnguyen on 25 September 2020, 09:19 
https://devapps.diality.us/cru/DIALIN-DEN-5053-1#c4918

  These should be placed in the common folder
  (common/msg_defs.py).

  Reply by Sean Nash on 29 September 2020, 15:52
  > Done.

    Reply by qnguyen on 29 September 2020, 16:16
    > RESOLVED.

Revision Comment by qnguyen on 25 September 2020, 09:21 
https://devapps.diality.us/cru/DIALIN-DEN-5053-1#c4919

  Should this be dialin to hd channel id?

  Reply by Sean Nash on 29 September 2020, 15:52
  > Done.

    Reply by qnguyen on 29 September 2020, 16:16
    > RESOLVED.

Revision Comment by qnguyen on 25 September 2020, 09:21 
https://devapps.diality.us/cru/DIALIN-DEN-5053-1#c4920

  Should this be dialin to hd channel id?

  Reply by Sean Nash on 29 September 2020, 15:52
  > Done.

    Reply by qnguyen on 29 September 2020, 16:16
    > RESOLVED.

----------------------------------------
File: dialin/dg/dialysate_generator.py
Revision Comment by qnguyen on 25 September 2020, 09:18 
https://devapps.diality.us/cru/DIALIN-DEN-5053-1#c4917

  Should it be dialin to dg channel?

  Reply by Sean Nash on 29 September 2020, 15:52
  > Done.

    Reply by qnguyen on 29 September 2020, 16:15
    > RESOLVED.

----------------------------------------
File: dialin/hd/hemodialysis_device.py
Revision Comment by plucia on 30 September 2020, 09:39 
https://devapps.diality.us/cru/DIALIN-DEN-5053-1#c4949

  These message IDs should also be in common

  Reply by Sean Nash on 30 September 2020, 10:20
  > Done.

    Reply by plucia on 30 September 2020, 10:54
    > RESOLVED


---

ID: DIALIN-DEN-5053-1 https://devapps.diality.us/cru/DIALIN-DEN-5053-1

Title: DIALIN-DEN-5053_HD Air Trap
Statement of Objectives:


State: Closed

Summary: 

Author: Sean Nash
Moderator: Sean Nash
Reviewers: (0 active, 3 completed*)
     qnguyen   (*)
     plucia   (*)
     pmontazemi   (*)