This is a list of all comments for DIALIN-DEN-5283-1.

Review Summary: No summary


----------------------------------------
File: dialin/squish/denaliMessages.py
Revision Comment by pmontazemi on 19 October 2020, 10:07 
https://devapps.diality.us/cru/DIALIN-DEN-5283-1#c5572

  Remove extra spaces between parameters and = sign.

  Reply by Behrouz NematiPour on 19 October 2020, 10:12
  > That's the vertical alignment of values for the same category
  > variables to find assigned values easily.
  > Enhance readability. The assignments are easier to spot
  > compare to each other.

    Reply by pmontazemi on 20 October 2020, 10:46
    > RESOLVED.

Revision Comment by pmontazemi on 19 October 2020, 10:08 
https://devapps.diality.us/cru/DIALIN-DEN-5283-1#c5573

  Remove extra lines (all)

  Reply by Behrouz NematiPour on 19 October 2020, 10:40
  > Removed.

    Reply by pmontazemi on 20 October 2020, 10:46
    > RESOLVED.

Revision Comment by plucia on 19 October 2020, 13:56 
https://devapps.diality.us/cru/DIALIN-DEN-5283-1#c5606

  The comparison to None should be {code}if vSecsRem is None:
  {code}

  Reply by Behrouz NematiPour on 19 October 2020, 15:00
  > done.
  > thanks for the comment.

    Reply by plucia on 19 October 2020, 15:05
    > RESOLVED

Revision Comment by plucia on 19 October 2020, 13:57 
https://devapps.diality.us/cru/DIALIN-DEN-5283-1#c5607

  These should be deleted. There should be 2 lines between each
  function. 1 line between each method in a class

  Reply by Behrouz NematiPour on 19 October 2020, 15:00
  > removed.
  > applied the described rules.

    Reply by plucia on 19 October 2020, 15:05
    > RESOLVED


---

ID: DIALIN-DEN-5283-1 https://devapps.diality.us/cru/DIALIN-DEN-5283-1

Title: DIALIN-DEN-5283_Saline Bolus FW Modification
Statement of Objectives:
DEN-5352: Unit Testing, DEN-5353: Integration Testing

State: Closed

Summary: 

Author: Behrouz NematiPour
Reviewers: (0 active, 2 completed*)
     plucia   (*)
     pmontazemi   (*)