DIALIN-DEN-5638-1 DIALIN-DEN-5638_Sprint 32

closed on 27 Jan 21

Author

Reviewers

DIALIN-DEN-5638_Sprint 32

Activity

Details
Objectives
General Comments 2
Unresolved
Resolved
Number of files included: 24

dialin 0
- Folder dialin 0
  - Folder dg 0
    - File hd_proxy.py 0 Remove
    - File reservoirs.py 0 Remove
  - Folder hd 0
    - File dialysate_outlet_flow.py 0 Remove
    - File treatment.py 0 Remove
    - File ui_proxy.py 0 Remove
  - Folder protocols 0
    - File CAN.py 0 Remove
  - Folder squish 0
    - File README.md 0 Remove
    - File __init__.py 0 Remove
    - File crc.py 0 Remove
    - File denaliMessages.py 0 Remove
    - File globals.py 0 Remove
    - File messageBuilder.py 0 Remove
    - File unittests.py 0 Remove
    - File utils.py 0 Remove
  - Folder ui 0
    - File crc.py 0 Remove
    - File globals.py 0 Remove
    - File hd_simulator.py 3 Remove
    - File hd_simulator_alarms.py 0 Remove
    - File messageBuilder.py 0 Remove
    - File unittests.py 0 Remove
    - File utils.py 0 Remove
- Folder tests 0
  - Folder unit_tests 0
    - File test_imports.py 0 Remove
  - File test_ui_proxy.py 6 Remove
- File .gitignore 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
plucia (deleted user)	Author	1h 20m	5	The available log levels are listed in the docstring of t...
Behrouz NematiPour	Reviewer - Complete	1h 58m	6	RESOLVED
Sean Nash	Reviewer - Complete	3m
Total		3h 23m	11

Linked issues
- DEN-5638

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

plucia (deleted user)

Related testsuites review: http://dvm-linux02:8060/cru/#UI-DEN-5638-1CFR-20510

24 Nov 20

plucia (deleted user)

As of 12/30/2020, with these changes: Code Coverage: 100% Squish Tests Passin...

As of 12/30/2020, with these changes:
Code Coverage: 100%
Squish Tests Passing: 100%

30 Dec 20

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

DIALIN-DEN-5638-1

DIALIN-DEN-5638_Sprint 32

DIALIN-DEN-5638-1 11

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

plucia (deleted user)

plucia (deleted user)

Log time

DIALIN-DEN-5638_Sprint 32

DIALIN-DEN-5638-1 11

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

plucia (deleted user)

plucia (deleted user)

Log time