This is a list of all comments for DIALIN-DEN-5638-1.

Review Summary: No summary

General Comment by plucia on 24 November 2020, 14:14 
https://devapps.diality.us/cru/DIALIN-DEN-5638-1#c6305

  Related testsuites review:
  http://dvm-linux02:8060/cru/UI-DEN-5638-1#CFR-20510

General Comment by plucia on 30 December 2020, 09:33 
https://devapps.diality.us/cru/DIALIN-DEN-5638-1#c6934

  As of 12/30/2020, with these changes:
  Code Coverage: 100%
  Squish Tests Passing: 100%


----------------------------------------
File: dialin/ui/hd_simulator.py
Revision Comment by Behrouz NematiPour on 24 January 2021, 11:18 
https://devapps.diality.us/cru/DIALIN-DEN-5638-1#c7564

  Is it still required while you have the time entirely imported
  at line 20?

  Reply by plucia on 25 January 2021, 11:02
  > No, thanks. I've now removed 
  > {code} import time {code}

    Reply by Behrouz NematiPour on 26 January 2021, 01:44
    > RESOLVED

----------------------------------------
File: tests/test_ui_proxy.py
Revision Comment by Behrouz NematiPour on 22 January 2021, 21:25 
https://devapps.diality.us/cru/DIALIN-DEN-5638-1#c7561

  Where this IP is used and what is the use case and what device
  is this IP refer to?

  Reply by plucia on 25 January 2021, 10:58
  > Looks like it has not been used anymore so I've deleted it.

    Reply by Behrouz NematiPour on 26 January 2021, 01:45
    > RESOLVED

Revision Comment by Behrouz NematiPour on 22 January 2021, 21:26 
https://devapps.diality.us/cru/DIALIN-DEN-5638-1#c7562

  Why enum is not used?

  Reply by plucia on 25 January 2021, 11:28
  > The available log levels are listed in the docstring of the
  > HD constructor. 
  > It simplifies debugging someone's script to not have to
  > import dialin logging levels when we need to debug their
  > code.
  > Since the HD/DG logging is not intended to be used by dialin
  > script writers, and is a dialin developer-only capability,
  > adding enum imports to user scripts when we want to debug
  > their code would be an unnecessary hindrance.

    Reply by Behrouz NematiPour on 26 January 2021, 01:44
    > RESOLVED


---

ID: DIALIN-DEN-5638-1 https://devapps.diality.us/cru/DIALIN-DEN-5638-1

Title: DIALIN-DEN-5638_Sprint 32
Statement of Objectives:


State: Closed

Summary: 

Author: plucia
Reviewers: (0 active, 2 completed*)
     Sean Nash   (*)
     Behrouz NematiPour   (*)