This is a list of all comments for DIALIN-DEN-5674-2.

Review Summary: No summary


----------------------------------------
File: dialin/hd/ui_proxy.py
Revision Comment by plucia on 30 December 2020, 09:40 
https://devapps.diality.us/cru/DIALIN-DEN-5674-2#c6935

  To avoid copying the has_value function into each enum
  sub-class, it'd be better to make AlarmUserOptions a subclass
  of DialinEnum, which can be imported from utils/base.py

  Reply by Sean Nash on 06 January 2021, 13:20
  > I don't have that class in my branch.

    Reply by plucia on 06 January 2021, 14:20
    > Okay, it can be addressed after you merge
    > 
    > RESOLVED

Revision Comment by plucia on 30 December 2020, 09:43 
https://devapps.diality.us/cru/DIALIN-DEN-5674-2#c6936

  Shouldn't the treatment parameters be published here like they
  are in _handler_treatment_param_settings?

  Reply by Sean Nash on 06 January 2021, 14:04
  > Done.

    Reply by plucia on 06 January 2021, 14:15
    > RESOLVED


---

ID: DIALIN-DEN-5674-2 https://devapps.diality.us/cru/DIALIN-DEN-5674-2

Title: DIALIN-DEN-5674_HD Alarm Design (3 of 4)
Statement of Objectives:


State: Closed

Summary: 

Author: Sean Nash
Reviewers: (0 active, 2 completed*)
     plucia   (*)
     pmontazemi   (*)