DIALIN-DEN-5751-1 DIALIN-DEN-5751_Pre Treatment Ultrafiltration

closed on 01 Feb 21

Author

Reviewers

DIALIN-DEN-5751_Pre Treatment Ultrafiltration

Activity

Details
Objectives
General Comments 1
Unresolved
Resolved
Number of files included: 70

dialin 0
- Folder dialin 0
  - Folder common 0
    - File hd_defs.py 0 Remove
    - File msg_defs.py 0 Remove
    - File prs_defs.py 0 Remove
  - Folder dg 0
    - File accelerometer.py 0 Remove
    - File concentrate_pumps.py 0 Remove
    - File conductivity_sensors.py 3 Remove
    - File dialysate_generator.py 0 Remove
    - File drain_pump.py 0 Remove
    - File fans.py 0 Remove
    - File hd_proxy.py 0 Remove
    - File heat_disinfection.py 0 Remove
    - File heaters.py 0 Remove
    - File load_cells.py 0 Remove
    - File pressures.py 0 Remove
    - File reservoirs.py 0 Remove
    - File ro_pump.py 0 Remove
    - File temperature_sensors.py 0 Remove
    - File thermistors.py 0 Remove
    - File uv_reactors.py 0 Remove
    - File valves.py 0 Remove
  - Folder hd 0
    - File accelerometer.py 0 Remove
    - File alarms.py 3 Remove
    - File blood_flow.py 0 Remove
    - File constants.py 0 Remove
    - File dialysate_inlet_flow.py 0 Remove
    - File dialysate_outlet_flow.py 0 Remove
    - File hemodialysis_device.py 0 Remove
    - File pressure_occlusion.py 0 Remove
    - File rtc.py 0 Remove
    - File treatment.py 0 Remove
    - File ui_proxy.py 0 Remove
  - Folder protocols 0
    - File CAN.py 6 Remove
  - Folder squish 0
    - File README.md 0 Remove
    - File __init__.py 0 Remove
    - File crc.py 0 Remove
    - File denaliMessages.py 3 Remove
    - File globals.py 0 Remove
    - File messageBuilder.py 0 Remove
    - File unittests.py 0 Remove
    - File utils.py 0 Remove
  - Folder ui 0
    - File __init__.py 0 Remove
    - File crc.py 0 Remove
    - File globals.py 0 Remove
    - File hd_simulator.py 0 Remove
    - File hd_simulator_alarms.py 0 Remove
    - File messageBuilder.py 0 Remove
    - File unittests.py 0 Remove
    - File utils.py 0 Remove
  - Folder utils 0
    - File base.py 0 Remove
- Folder tests 0
  - Folder unit_tests 0
    - File test_dg_temperature_sensors.py 0 Remove
    - File test_imports.py 0 Remove
    - File test_ui_proxy.py 0 Remove
  - File dg_heat_disinfect_test.py 0 Remove
  - File dg_heatdisinfect.py 0 Remove
  - File send_malformed_message.sh 0 Remove
  - File set_accels_cal.py 3 Remove
  - File set_flow_sensors_cal.py 0 Remove
  - File test_debug_text.py 0 Remove
  - File test_gen_requirements.py 3 Remove
  - File test_hd.py 0 Remove
  - File test_hd_simulator.py 3 Remove
  - File test_logging.py 0 Remove
  - File test_uf.py 0 Remove
  - File test_ui_proxy.py 0 Remove
  - File uf_test.py 3 Remove
- Folder tools 0
  - File cr_objectives.sh 0 Remove
- File .gitignore 0 Remove
- File CHANGELOG.md 0 Remove
- File cr_objectives.sh 0 Remove
- File version.py 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Behrouz NematiPour	Author	1h 31m	10	Please refer to the general comment I put, These codes ar...
plucia (deleted user)	Reviewer - Complete	32m	2	will be addressed later, RESOLVED
pmontazemi (deleted user)	Reviewer - Complete	32m	16	RESOLVED.
Total		2h 36m	28

Linked issues
- DEN-5736
- DEN-5751
- DEN-5830
- DEN-5833

#permalink

Objectives

The only files that were involved in these changesets are:

dialin/ui/hd_simulator.py
dialin/common/msg_defs.py
dialin/squish/denaliMessages.py
And all the other files are merged from master and other branches which were merged into master.

Added cmd_set_treatment_adjust_ultrafiltration_init_response
Fixing priming message ID
This was causing the tst_confirmprimingbegin not to receive the priming status message therefore couldn't reach 100% coverage.
moved the cr shell script into the tools folder.
added the message-id 80 for prTx UF adj rsp.
Added API for the message 63: Alarm Condition Cleared
Added AlarmFlags
Added Alarms Priority enums in the common folder.
Updated the CANBus test function test_can0 to be able to be used outside of the SquishQt (ex. Simulator) and moved the common portion in the utils.py

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Behrouz NematiPour

Also mentioned in the objectives: The only files that were involved in these...

Also mentioned in the objectives:

The only files that were involved in these changesets are:

dialin/ui/hd_simulator.py
dialin/common/msg_defs.py
dialin/squish/denaliMessages.py
And all the other files are merged from master and other branches which were merged into master.

25 Jan 21

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

DIALIN-DEN-5751-1

DIALIN-DEN-5751_Pre Treatment Ultrafiltration

DIALIN-DEN-5751-1 28

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Behrouz NematiPour

Log time

DIALIN-DEN-5751_Pre Treatment Ultrafiltration

DIALIN-DEN-5751-1 28

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Behrouz NematiPour

Log time