DIALIN-DEN-5830-2 DIALIN-DEN-5830_Alarm Design

closed on 20 Jan 21

Author

Reviewers

DIALIN-DEN-5830_Alarm Design

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 6

dialin 0
- Folder dialin 0
  - Folder common 0
    - File prs_defs.py 0 Remove
  - Folder squish 0
    - File denaliMessages.py 0 Remove
    - File unittests.py 6 Remove
    - File utils.py 0 Remove
- Folder tools 0
  - File cr_objectives.sh 0 Remove
- File cr_objectives.sh 7 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Behrouz NematiPour	Author	25m	5	moved to tools folder
plucia (deleted user)	Reviewer - Complete	37m	8	RESOLVED
pmontazemi (deleted user)	Reviewer - Complete	2m
Total		1h 5m	13

Linked issues
- DEN-5736
- DEN-5833

#permalink

Objectives

Summary:

Added API for the message 63: Alarm Condition Cleared
Added AlarmFlags
Added Alarms Priority enums in the common folder.
Updated the CANBus test function test_can0 to be able to be used outside of the SquishQt (ex. Simulator) and moved the common portion in the utils.py

----- By Commit
commit : 00e1e2f - DEN-5833: Implementation

Added API for the message 63: Alarm Condition Cleared

commit : f7da817 - DEN-5833: Implementation

Added AlarmFlags

commit : 2029044 - DEN-5833: Implementation

Added Alarms Priority enums in the common folder.
Updated the CANBus test function test_can0 to be able to be used out side of the SquishQt (ex. Simulator) and moved the common portion in the utils.py

commit : a5e1daa

Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

DIALIN-DEN-5830-2

DIALIN-DEN-5830_Alarm Design

DIALIN-DEN-5830-2 13

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

DIALIN-DEN-5830_Alarm Design

DIALIN-DEN-5830-2 13

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time