This is a list of all comments for DIALIN-DEN-5830-2.

Review Summary: No summary


----------------------------------------
File: dialin/squish/unittests.py
Revision Comment by plucia on 13 January 2021, 11:46 
https://devapps.diality.us/cru/DIALIN-DEN-5830-2#c7311

  Unused import

  Reply by Behrouz NematiPour on 13 January 2021, 17:03
  > Good catch, thanks.
  > Removed.
  > It seems SquishQt tries to add packages and when I am going
  > to use 'utils' without importing it, SquishQt tries to import
  > it but from the wrong package.

    Reply by plucia on 13 January 2021, 17:12
    > RESOLVED

Revision Comment by plucia on 13 January 2021, 11:47 
https://devapps.diality.us/cru/DIALIN-DEN-5830-2#c7312

  Unused import

  Reply by Behrouz NematiPour on 13 January 2021, 17:05
  > same here,
  > removed.

    Reply by plucia on 13 January 2021, 17:12
    > RESOLVED

----------------------------------------
File: cr_objectives.sh
Revision Comment by plucia on 13 January 2021, 17:13 
https://devapps.diality.us/cru/DIALIN-DEN-5830-2#c7337

  This should go in the tools directory with the other helper
  scripts

  Reply by Behrouz NematiPour on 14 January 2021, 15:12
  > Sure, 
  > I am testing the idea.
  > It's not mature yet.
  > Will complete that and will move in the script repository
  > later and use that for all the three repositories.

    Reply by plucia on 18 January 2021, 11:26
    > It's not a separate repository it's just a folder in the
    > dialin repository called "tools"
    > Right now this script exists in the root folder when it
    > should reside in the "tools" directory

      Reply by Behrouz NematiPour on 18 January 2021, 12:08
      > There is a script repository in which we keep all the
      > general/common scripts there and since it is not only
      > Dialin related preferred to keep it there.
      > ssh://git@192.168.10.132:7999/ui/scripts.git

        Reply by plucia on 19 January 2021, 08:02
        > Okay then it should be deleted from dialin, no?

          Reply by Behrouz NematiPour on 19 January 2021, 11:29
          > moved to tools folder

          Reply by plucia on 19 January 2021, 14:38
          > RESOLVED


---

ID: DIALIN-DEN-5830-2 https://devapps.diality.us/cru/DIALIN-DEN-5830-2

Title: DIALIN-DEN-5830_Alarm Design
Statement of Objectives:
Summary:
 - Added API for the message 63: Alarm Condition Cleared
 - Added AlarmFlags
 - Added Alarms Priority enums in the common folder.
 - Updated the CANBus test function test_can0 to be able to be used outside of the SquishQt (ex. Simulator) and moved the common portion in the utils.py


 ----- By Commit
commit : [00e1e2f|http://192.168.10.132:7990/projects/VV/repos/dialin/commits/00e1e2f] - DEN-5833: Implementation
 - Added API for the message 63: Alarm Condition Cleared

commit : [f7da817|http://192.168.10.132:7990/projects/VV/repos/dialin/commits/f7da817] - DEN-5833: Implementation
 - Added AlarmFlags

commit : [2029044|http://192.168.10.132:7990/projects/VV/repos/dialin/commits/2029044] - DEN-5833: Implementation
 - Added Alarms Priority enums in the common folder.
 - Updated the CANBus test function test_can0 to be able to be used out side of the SquishQt (ex. Simulator) and moved the common portion in the utils.py

commit : [a5e1daa|http://192.168.10.132:7990/projects/VV/repos/dialin/commits/a5e1daa] 
 - Bamboo Commit: Updated the Copyright with the current year and replaced tabs with 4 spaces


State: Closed

Summary: 

Author: Behrouz NematiPour
Reviewers: (0 active, 2 completed*)
     plucia   (*)
     pmontazemi   (*)