This is a list of all comments for DIALIN-DEN-6078-1.

Review Summary: No summary


----------------------------------------
File: dialin/hd/valves.py
Revision Comment by plucia on 25 January 2021, 12:19 
https://devapps.diality.us/cru/DIALIN-DEN-6078-1#c7593

  The logger parameter is missing from the docstring

  Reply by Dara Navaei on 20 February 2021, 14:19
  > Done

    Reply by plucia on 22 February 2021, 09:06
    > These still need to be updated
    > outer_instance can be removed, and can_interface needs to
    > be added. the logger parameter description isn't right as
    > the deprecated outer_instance parameter was a reference to
    > the DG (outer) class, not the logger parameter

      Reply by Dara Navaei on 22 February 2021, 13:21
      > Done

        Reply by plucia on 22 February 2021, 13:37
        > RESOLVED

Revision Comment by plucia on 25 January 2021, 12:17 
https://devapps.diality.us/cru/DIALIN-DEN-6078-1#c7590

  The reset parameter is missing from the docstring

  Reply by Dara Navaei on 20 February 2021, 14:22
  > Done

    Reply by plucia on 22 February 2021, 09:04
    > RESOLVED

Revision Comment by plucia on 25 January 2021, 12:17 
https://devapps.diality.us/cru/DIALIN-DEN-6078-1#c7591

  The reset parameter is missing from the docstring

  Reply by Dara Navaei on 20 February 2021, 14:22
  > Done

    Reply by plucia on 22 February 2021, 09:03
    > RESOLVED

Revision Comment by plucia on 25 January 2021, 12:18 
https://devapps.diality.us/cru/DIALIN-DEN-6078-1#c7592

  The valve_state is missing from the docstring

  Reply by Dara Navaei on 20 February 2021, 14:20
  > Done

    Reply by plucia on 22 February 2021, 09:02
    > RESOLVED

----------------------------------------
File: tests/hd_valves_test.py
Revision Comment by qnguyen on 14 January 2021, 19:21 
https://devapps.diality.us/cru/DIALIN-DEN-6078-1#c7393

  Do we need this import?

  Reply by Dara Navaei on 20 January 2021, 10:23
  > We don't anymore. I removed it.

    Reply by qnguyen on 20 January 2021, 11:37
    > RESOLVED.

Revision Comment by qnguyen on 14 January 2021, 19:19 
https://devapps.diality.us/cru/DIALIN-DEN-6078-1#c7392

  Remove extra lines.

  Reply by Dara Navaei on 20 January 2021, 10:24
  > Done

    Reply by qnguyen on 20 January 2021, 11:37
    > RESOLVED.


---

ID: DIALIN-DEN-6078-1 https://devapps.diality.us/cru/DIALIN-DEN-6078-1

Title: DIALIN-DEN-6078_Revisit Safety And Functionality of Pumps And Valves
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Reviewers: (0 active, 3 completed*)
     qnguyen   (*)
     Sean Nash   (*)
     plucia   (*)