DIALIN-DEN-6372_HD Rinseback

Activity

DIALIN-DEN-6372-1 6

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 10m 2 Done.
    plucia  (deleted user)
    Reviewer completed
    Reviewer - Complete 7m    
    pmontazemi  (deleted user)
    Reviewer completed
    Reviewer - Complete 33m 4 RESOLVED.
    Total   50m 6  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /dialin/common/AlarmIds.txt Changed
    /dialin/common/alarm_defs.py Changed
    /dialin/common/msg_defs.py Changed
    /dialin/dg/concentrate_pumps.py Changed
    /dialin/dg/conductivity_sensors.py Changed
    /dialin/dg/dialysate_generator.py Changed
    /dialin/hd/alarms.py Changed
    /dialin/hd/hemodialysis_device.py Changed
    /dialin/hd/pressure_occlusion.py Changed
    /dialin/hd/treatment.py Changed
    /dialin/hd/ui_proxy.py Changed
    /dialin/hd/valves.py Changed
    /dialin/protocols/CAN.py Changed
    /dialin/protocols/__init__.py Changed
    /dialin/squish/README.md Deleted
    Open in IDE #permalink
    /dialin/squish/__init__.py Deleted
    Open in IDE #permalink
    /dialin/squish/crc.py Deleted
    Open in IDE #permalink
    /dialin/squish/denaliMessages.py Deleted
    Open in IDE #permalink
    /dialin/squish/messageBuilder.py Deleted
    Open in IDE #permalink
    /dialin/squish/unittests.py Deleted
    Open in IDE #permalink
    /dialin/squish/utils.py Deleted
    Open in IDE #permalink
    /dialin/ui/hd_simulator.py Changed 3
    /dialin/ui/hd_simulator_alarms.py Changed
    /dialin/utils/__init__.py Changed
    /dialin/utils/conversions.py Changed
    /dialin/version.py Changed
    /tests/hd_valves_test.py Changed
    Open in IDE #permalink
    /tests/test_blood_flow.py Added
    Open in IDE #permalink
    /tests/test_fw_controller.py Added
    /tests/test_hd_reset.py Changed
    /tests/test_hd_valves.py Changed
    Open in IDE #permalink
    /tests/test_heparin.py Added
    Open in IDE #permalink
    /tests/test_uf.py Changed 3
    Open in IDE #permalink
    /tools/cr_objectives.sh Added
    Open in IDE #permalink
    /CHANGELOG.md Changed
    /cr_objectives.sh Deleted
    Open in IDE #permalink
    /version.py Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time