This is a list of all comments for DIALIN-DEN-7135-1.

Review Summary: No summary


----------------------------------------
File: dialin/ui/hd_simulator.py
Revision Comment by pmontazemi on 01 April 2021, 10:36 
https://devapps.diality.us/cru/DIALIN-DEN-7135-1#c8917

  Remove extra line.

  Reply by Behrouz NematiPour on 11 April 2021, 14:14
  > Removed.

    Reply by pmontazemi on 13 April 2021, 14:50
    > RESOLVED.

Revision Comment by pmontazemi on 01 April 2021, 10:36 
https://devapps.diality.us/cru/DIALIN-DEN-7135-1#c8918

  Either remove commented lines or add TODO in comment.

  Reply by Behrouz NematiPour on 11 April 2021, 14:14
  > Put the TODO comment

    Reply by pmontazemi on 13 April 2021, 14:51
    > RESOLVED.

Revision Comment by plucia on 01 April 2021, 14:52 
https://devapps.diality.us/cru/DIALIN-DEN-7135-1#c8935

  As we discussed these handler functions should be updated to
  work with the latest pre treatment messaging changes

  Reply by Behrouz NematiPour on 11 April 2021, 14:17
  > If you don't mind let's address it in the "DEN-7820:UI_DEV:
  > Post-Treatment" story.

    Reply by plucia on 12 April 2021, 10:08
    > RESOLVED
    > Sounds good. Thanks!

Revision Comment by pmontazemi on 01 April 2021, 10:36 
https://devapps.diality.us/cru/DIALIN-DEN-7135-1#c8919

  Either remove commented lines or add TODO in comment.

  Reply by Behrouz NematiPour on 11 April 2021, 14:06
  > After the change in the messaging structure these codes were
  > not working so I commented them out to let the simulator
  > work.
  > But kept as the guidelines of how the implementation needs to
  > change.
  > Also, there's a comment to update then with the new
  > messaging.
  > Put the TODO comment.

    Reply by pmontazemi on 13 April 2021, 14:50
    > RESOLVED.

----------------------------------------
File: dialin/common/msg_defs.py
Revision Comment by pmontazemi on 01 April 2021, 10:35 
https://devapps.diality.us/cru/DIALIN-DEN-7135-1#c8916

  Why not align all of them then?

  Reply by Behrouz NematiPour on 11 April 2021, 14:05
  > I didn't want to change all the others to be aligned since it
  > makes it confusing that what was actually required for the
  > content of the change.
  > If needed let me know to make those two to be like the
  > others.

    Reply by pmontazemi on 13 April 2021, 14:50
    > RESOLVED.


---

ID: DIALIN-DEN-7135-1 https://devapps.diality.us/cru/DIALIN-DEN-7135-1

Title: DIALIN-DEN-7135_UI Pre Treatment
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Reviewers: (0 active, 2 completed*)
     plucia   (*)
     pmontazemi   (*)