This is a list of all comments for DIALIN-DEN-7395-1.

Review Summary: No summary


----------------------------------------
File: dialin/hd/blood_leak.py
Revision Comment by qnguyen on 19 April 2021, 10:50 
https://devapps.diality.us/cru/DIALIN-DEN-7395-1#c9478

  Filename mismatch.

  Reply by pmontazemi on 19 April 2021, 15:40
  > Addressed.

    Reply by qnguyen on 19 April 2021, 16:10
    > RESOLVED.

Revision Comment by Sean Nash on 19 April 2021, 11:00 
https://devapps.diality.us/cru/DIALIN-DEN-7395-1#c9493

  Msg ID should be for the data broadcast message, not the
  override msg.

  Reply by pmontazemi on 19 April 2021, 15:39
  > Addressed.

    Reply by Sean Nash on 19 April 2021, 15:42
    > RESOLVED.

Revision Comment by Sean Nash on 19 April 2021, 11:07 
https://devapps.diality.us/cru/DIALIN-DEN-7395-1#c9499

  Add another class variable for state.

  Reply by pmontazemi on 19 April 2021, 15:37
  > Addressed.

    Reply by Sean Nash on 19 April 2021, 15:42
    > RESOLVED.

Revision Comment by Sean Nash on 19 April 2021, 11:04 
https://devapps.diality.us/cru/DIALIN-DEN-7395-1#c9497

  According to message list, there should be 2 parameters in the
  blood leak data message: 1) status and 2) state.

  Reply by pmontazemi on 19 April 2021, 15:27
  > Addressed.

    Reply by Sean Nash on 19 April 2021, 15:43
    > RESOLVED.

Revision Comment by Sean Nash on 19 April 2021, 11:08 
https://devapps.diality.us/cru/DIALIN-DEN-7395-1#c9500

  I don't think you have a variable defined for state yet.

  Reply by pmontazemi on 19 April 2021, 15:33
  > Addressed in Class definition section and __init__(...)

    Reply by Sean Nash on 19 April 2021, 15:43
    > RESOLVED.

Revision Comment by Sean Nash on 19 April 2021, 11:09 
https://devapps.diality.us/cru/DIALIN-DEN-7395-1#c9502

  Remove this constraint.

  Reply by pmontazemi on 19 April 2021, 15:24
  > Addressed.

    Reply by Sean Nash on 19 April 2021, 15:43
    > RESOLVED.

Revision Comment by Sean Nash on 19 April 2021, 11:09 
https://devapps.diality.us/cru/DIALIN-DEN-7395-1#c9501

  Looks like copy from fluid leak class.  Update for blood leak.

  Reply by pmontazemi on 19 April 2021, 15:24
  > Addressed.

    Reply by Sean Nash on 19 April 2021, 15:43
    > RESOLVED.

Revision Comment by Sean Nash on 19 April 2021, 11:10 
https://devapps.diality.us/cru/DIALIN-DEN-7395-1#c9503

  Change "priority" to "general" and 10ms to 50ms.

  Reply by pmontazemi on 19 April 2021, 15:23
  > Addressed.

    Reply by Sean Nash on 19 April 2021, 15:44
    > RESOLVED.

Revision Comment by qnguyen on 20 April 2021, 22:49 
https://devapps.diality.us/cru/DIALIN-DEN-7395-1#c9529

  Rename blood_leak_state to blood_leak_data.

  Reply by pmontazemi on 21 April 2021, 11:55
  > Addressed.

    Reply by qnguyen on 21 April 2021, 11:57
    > RESOLVED.


---

ID: DIALIN-DEN-7395-1 https://devapps.diality.us/cru/DIALIN-DEN-7395-1

Title: DIALIN-DEN-7395_Blood Leak Detector
Statement of Objectives:


State: Closed

Summary: 

Author: pmontazemi
Moderator: pmontazemi
Reviewers: (0 active, 3 completed*)
     qnguyen   (*)
     Sean Nash   (*)
     plucia   (*)