This is a list of all comments for DIALIN-DEN-7605-1.

Review Summary: No summary


----------------------------------------
File: dialin/dg/voltages.py
Revision Comment by plucia on 05 May 2021, 09:53 
https://devapps.diality.us/cru/DIALIN-DEN-7605-1#c9749

  Needs a return type

  Reply by Sean Nash on 06 May 2021, 10:37
  > Fixed.

    Reply by plucia on 11 May 2021, 12:25
    > RESOLVED

Revision Comment by plucia on 05 May 2021, 09:54 
https://devapps.diality.us/cru/DIALIN-DEN-7605-1#c9750

  Needs a return type

  Reply by Sean Nash on 06 May 2021, 10:36
  > Fixed.

    Reply by plucia on 11 May 2021, 12:25
    > RESOLVED

----------------------------------------
File: dialin/hd/fluid_leak.py
Revision Comment by plucia on 05 May 2021, 09:54 
https://devapps.diality.us/cru/DIALIN-DEN-7605-1#c9751

  Typing information missing for parameters
  Return type missing

  Reply by Sean Nash on 06 May 2021, 10:35
  > Fixed.

    Reply by plucia on 11 May 2021, 12:25
    > RESOLVED

Revision Comment by plucia on 05 May 2021, 09:54 
https://devapps.diality.us/cru/DIALIN-DEN-7605-1#c9752

  Typing information missing for parameters
  Return type is missing

  Reply by Sean Nash on 06 May 2021, 10:35
  > Fixed.

    Reply by plucia on 11 May 2021, 12:25
    > RESOLVED

----------------------------------------
File: dialin/hd/voltages.py
Revision Comment by plucia on 05 May 2021, 09:57 
https://devapps.diality.us/cru/DIALIN-DEN-7605-1#c9757

  Needs a return type

  Reply by Sean Nash on 06 May 2021, 10:33
  > Done.

    Reply by plucia on 11 May 2021, 12:24
    > RESOLVED

Revision Comment by plucia on 05 May 2021, 09:57 
https://devapps.diality.us/cru/DIALIN-DEN-7605-1#c9758

  Needs a return type

  Reply by Sean Nash on 06 May 2021, 10:30
  > Done.

    Reply by plucia on 11 May 2021, 12:24
    > RESOLVED

----------------------------------------
File: dialin/hd/syringe_pump.py
Revision Comment by plucia on 05 May 2021, 09:52 
https://devapps.diality.us/cru/DIALIN-DEN-7605-1#c9745

  Please add the return type as int
  {code} reset:int=NO_RESET) -> int: {code}

  Reply by Sean Nash on 06 May 2021, 10:39
  > Fixed.

    Reply by plucia on 11 May 2021, 12:24
    > RESOLVED

Revision Comment by plucia on 05 May 2021, 09:53 
https://devapps.diality.us/cru/DIALIN-DEN-7605-1#c9746

  Needs a return type

  Reply by Sean Nash on 06 May 2021, 10:39
  > Fixed.

    Reply by plucia on 11 May 2021, 12:24
    > RESOLVED

Revision Comment by plucia on 05 May 2021, 09:53 
https://devapps.diality.us/cru/DIALIN-DEN-7605-1#c9747

  Needs a return type

  Reply by Sean Nash on 06 May 2021, 10:39
  > Fixed.

    Reply by plucia on 11 May 2021, 12:24
    > RESOLVED

Revision Comment by plucia on 05 May 2021, 09:53 
https://devapps.diality.us/cru/DIALIN-DEN-7605-1#c9748

  Needs a return type

  Reply by Sean Nash on 06 May 2021, 10:39
  > Fixed.

    Reply by plucia on 11 May 2021, 12:23
    > RESOLVED

----------------------------------------
File: dialin/dg/scheduled_runs_record.py
Revision Comment by plucia on 01 June 2021, 10:49 
https://devapps.diality.us/cru/DIALIN-DEN-7605-1#c10182

  Is there a problem with crc_16? Or, what needs to be fixed
  still?

  Reply by Sean Nash on 03 June 2021, 09:32
  > This is Dara's code.  Dara will fix in his DIALIN-DEN-8030
  > branch.

    Reply by plucia on 03 June 2021, 09:54
    > RESOLVED

----------------------------------------
File: dialin/utils/checks.py
Revision Comment by plucia on 01 June 2021, 10:47 
https://devapps.diality.us/cru/DIALIN-DEN-7605-1#c10181

  In __init__.py you should add from .checks import * so that
  someone can import the check from utils without having to know
  which file it is in

  Reply by Sean Nash on 03 June 2021, 09:52
  > Fixed.

    Reply by plucia on 03 June 2021, 09:54
    > RESOLVED


---

ID: DIALIN-DEN-7605-1 https://devapps.diality.us/cru/DIALIN-DEN-7605-1

Title: DIALIN-DEN-7605_HD DG Self Tests
Statement of Objectives:


State: Closed

Summary: 

Author: Sean Nash
Moderator: Sean Nash
Reviewers: (0 active, 2 completed*)
     plucia   (*)
     pmontazemi   (*)