This is a list of all comments for DIALIN-DEN-7792-1.

Review Summary: No summary


----------------------------------------
File: dialin/dg/hd_proxy.py
Revision Comment by qnguyen on 14 April 2021, 11:40 
https://devapps.diality.us/cru/DIALIN-DEN-7792-1#c9283

  Can we remove these message IDs here?

  Reply by plucia on 14 April 2021, 12:00
  > Good catch, I've removed them now

    Reply by qnguyen on 14 April 2021, 14:07
    > RESOLVED.

----------------------------------------
File: dialin/hd/ui_proxy.py
Revision Comment by qnguyen on 14 April 2021, 11:32 
https://devapps.diality.us/cru/DIALIN-DEN-7792-1#c9282

  This message ID should be MSG_ID_UI_INITIATE_TREATMENT_REQUEST
  (0x38).

  Reply by plucia on 14 April 2021, 11:55
  > Now fixed

    Reply by qnguyen on 14 April 2021, 14:07
    > RESOLVED.

----------------------------------------
File: tools/build_common_defs.py
Revision Comment by qnguyen on 14 April 2021, 14:11 
https://devapps.diality.us/cru/DIALIN-DEN-7792-1#c9290

  Mismatch filename.

  Reply by plucia on 21 April 2021, 13:29
  > Done

    Reply by qnguyen on 21 April 2021, 16:26
    > RESOLVED.

----------------------------------------
File: tools/gen_common_defs.sh
Revision Comment by qnguyen on 14 April 2021, 14:11 
https://devapps.diality.us/cru/DIALIN-DEN-7792-1#c9289

  Mismatch filename.

  Reply by plucia on 21 April 2021, 13:29
  > Done

    Reply by qnguyen on 21 April 2021, 16:26
    > RESOLVED.

----------------------------------------
File: tools/setup_env.sh
Revision Comment by qnguyen on 14 April 2021, 14:11 
https://devapps.diality.us/cru/DIALIN-DEN-7792-1#c9288

  Mismatch filename.

  Reply by plucia on 21 April 2021, 13:30
  > Done

    Reply by qnguyen on 21 April 2021, 16:26
    > RESOLVED.


---

ID: DIALIN-DEN-7792-1 https://devapps.diality.us/cru/DIALIN-DEN-7792-1

Title: DIALIN-DEN-7792_Sprint 42
Statement of Objectives:


State: Closed

Summary: 

Author: plucia
Reviewers: (0 active, 3 completed*)
     qnguyen   (*)
     Sean Nash   (*)
     pmontazemi   (*)