This is a list of all comments for DIALIN-DEN-8055-1.

Review Summary: No summary


----------------------------------------
File: dialin/hd/buttons.py
Revision Comment by Sean Nash on 29 April 2021, 08:49 
https://devapps.diality.us/cru/DIALIN-DEN-8055-1#c9641

  Remove obsolete definitions at top of class.

  Reply by plucia on 05 May 2021, 09:32
  > Done

    Reply by Sean Nash on 05 May 2021, 09:55
    > RESOLVED.

----------------------------------------
File: tests/test_calibration.py
Revision Comment by pmontazemi on 29 April 2021, 09:41 
https://devapps.diality.us/cru/DIALIN-DEN-8055-1#c9648

  Remove extra lines.

  Reply by plucia on 05 May 2021, 09:47
  > Done

    Reply by pmontazemi on 06 May 2021, 09:33
    > RESOLVED.

----------------------------------------
File: dialin/hd/calibration_record.py
Revision Comment by pmontazemi on 29 April 2021, 09:33 
https://devapps.diality.us/cru/DIALIN-DEN-8055-1#c9647

  "sent" instead of "send"

  Reply by Dara Navaei on 19 October 2023, 13:14
  > RESOLVED

----------------------------------------
File: dialin/hd/ui_proxy.py
Revision Comment by qnguyen on 29 April 2021, 14:35 
https://devapps.diality.us/cru/DIALIN-DEN-8055-1#c9681

  Recommend converting to use message field positions and remove
  local defines.

  Reply by Sean Nash on 04 May 2021, 09:20
  > These are 1 and 2 byte fields, so cannot use the generic
  > 4-byte field names.

    Reply by qnguyen on 04 May 2021, 10:24
    > RESOLVED.

----------------------------------------
File: dialin/dg/scheduled_runs_record.py
Revision Comment by pmontazemi on 29 April 2021, 09:30 
https://devapps.diality.us/cru/DIALIN-DEN-8055-1#c9645

  Where was CRC moved to?

  Reply by plucia on 05 May 2021, 09:37
  > It has been moved to nv_ops_utils.py:
  > {code}prepare_record_to_send_to_fw{code}

    Reply by pmontazemi on 06 May 2021, 09:33
    > RESOLVED.

----------------------------------------
File: dialin/common/msg_defs.py
Revision Comment by pmontazemi on 29 April 2021, 09:28 
https://devapps.diality.us/cru/DIALIN-DEN-8055-1#c9643

  Remove extra line.

  Reply by plucia on 05 May 2021, 09:32
  > Done

    Reply by pmontazemi on 06 May 2021, 09:34
    > RESOLVED.


---

ID: DIALIN-DEN-8055-1 https://devapps.diality.us/cru/DIALIN-DEN-8055-1

Title: DIALIN-DEN-8055_Sprint 43
Statement of Objectives:


State: Closed

Summary: 

Author: plucia
Reviewers: (1 active, 2 completed*)
     qnguyen   (*)
     pmontazemi   (*)
     Sean Nash