This is a list of all comments for DIALIN-DEN-8251-1.

Review Summary: No summary


----------------------------------------
File: dialin/hd/ui_proxy.py
Revision Comment by qnguyen on 14 May 2021, 10:41 
https://devapps.diality.us/cru/DIALIN-DEN-8251-1#c9861

  Change to return type to None and remove not needed return 0 to
  keep consistency with other functions in this file.

  Reply by plucia on 21 May 2021, 15:16
  > Done

    Reply by qnguyen on 21 May 2021, 16:36
    > RESOLVED.

----------------------------------------
File: dialin/utils/data_logger.py
Revision Comment by qnguyen on 05 May 2021, 23:08 
https://devapps.diality.us/cru/DIALIN-DEN-8251-1#c9762

  Need file header.

  Reply by plucia on 11 May 2021, 12:17
  > Done

    Reply by qnguyen on 11 May 2021, 13:46
    > RESOLVED.

----------------------------------------
File: dialin/utils/helpers.py
Revision Comment by qnguyen on 05 May 2021, 23:07 
https://devapps.diality.us/cru/DIALIN-DEN-8251-1#c9761

  Need file header (copyright, etc.)

  Reply by plucia on 11 May 2021, 12:18
  > Done

    Reply by qnguyen on 11 May 2021, 13:46
    > RESOLVED.

----------------------------------------
File: dialin/utils/singleton.py
Revision Comment by qnguyen on 05 May 2021, 23:06 
https://devapps.diality.us/cru/DIALIN-DEN-8251-1#c9760

  Mismatch filename.

  Reply by plucia on 11 May 2021, 12:19
  > Done

    Reply by qnguyen on 11 May 2021, 13:46
    > RESOLVED.

----------------------------------------
File: tests/peter/set_RTCs.py
Revision Comment by qnguyen on 21 May 2021, 10:29 
https://devapps.diality.us/cru/DIALIN-DEN-8251-1#c10000

  Will this path is enough to find dialin folder since this has
  been moved into another folder?

  Reply by plucia on 21 May 2021, 15:15
  > If you select Edit Configuration -> "add content roots" in
  > PyCharm, it will automatically add
  > /home/denali/Projects/dialin/ to your path before executing
  > the script and there is no longer a need to append to the
  > path in the script. I had selected this option and wasn't
  > having issue running any script.
  > I've updated all the paths now to support execution from
  > outside of PyCharm.

    Reply by qnguyen on 21 May 2021, 16:37
    > RESOLVED.

----------------------------------------
File: dialin/dg/fluid_leak.py
Revision Comment by qnguyen on 14 May 2021, 10:50 
https://devapps.diality.us/cru/DIALIN-DEN-8251-1#c9862

  This function and the one below needs to match the new style.

  Reply by plucia on 21 May 2021, 15:18
  > Done - just FYI I have added type hints in my Sprint 45
  > branch for the dg classes. So it hasn't been updated almost
  > everywhere inside the dg folder on this Sprint 44 branch

    Reply by qnguyen on 21 May 2021, 16:37
    > RESOLVED.


---

ID: DIALIN-DEN-8251-1 https://devapps.diality.us/cru/DIALIN-DEN-8251-1

Title: DIALIN-DEN-8251_Sprint 44
Statement of Objectives:


State: Closed

Summary: 

Author: plucia
Moderator: plucia
Reviewers: (0 active, 3 completed*)
     qnguyen   (*)
     Sean Nash   (*)
     pmontazemi   (*)