This is a list of all comments for DIALIN-DEN-8514-2.

Review Summary: No summary


----------------------------------------
File: dialin/ui/dg_simulator.py
Revision Comment by plucia on 15 June 2021, 16:35 
https://devapps.diality.us/cru/DIALIN-DEN-8514-2#c10254

  This function is a duplicate. Any reason not to update
  cmd_send_dg_serial without breaking backwards compatibility?

  Reply by Behrouz NematiPour on 17 June 2021, 10:19
  > - That function doesn't use the UI message Id and is using
  > dialin message-id enum which is not used in UI.
  >  - it doesn't get a parameter and is hardcoded.
  >  - I can remove that function if not being used anywhere
  > else.
  > Will take care of it in the code review of the next story.

    Reply by plucia on 02 July 2021, 11:15
    > RESOLVED

----------------------------------------
File: dialin/protocols/CAN.py
Revision Comment by pmontazemi on 24 June 2021, 08:11 
https://devapps.diality.us/cru/DIALIN-DEN-8514-2#c10314

  Remove spaces around "=" sign.

  Reply by Behrouz NematiPour on 02 July 2021, 11:12
  > Removed in the current working code.
  > Will be reviewed in the next review.

    Reply by pmontazemi on 02 July 2021, 11:17
    > RESOLVED.


---

ID: DIALIN-DEN-8514-2 https://devapps.diality.us/cru/DIALIN-DEN-8514-2

Title: DIALIN-DEN-8514_UI DEV Alarms Active List Merge Setting
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Reviewers: (0 active, 2 completed*)
     plucia   (*)
     pmontazemi   (*)