This is a list of all comments for DIALIN-DEN-8856-1.

Review Summary: No summary


----------------------------------------
File: dialin/protocols/CAN.py
Revision Comment by pmontazemi on 09 July 2021, 13:40 
https://devapps.diality.us/cru/DIALIN-DEN-8856-1#c10360

  Denali with capital "D".

  Reply by qnguyen on 19 July 2021, 09:31
  > Done.

    Reply by pmontazemi on 19 July 2021, 09:50
    > RESOLVED.

Revision Comment by pmontazemi on 09 July 2021, 13:40 
https://devapps.diality.us/cru/DIALIN-DEN-8856-1#c10361

  CAN instead of can

  Reply by qnguyen on 19 July 2021, 09:31
  > Done.

    Reply by pmontazemi on 19 July 2021, 09:49
    > RESOLVED.

Revision Comment by Sean Nash on 20 July 2021, 13:19 
https://devapps.diality.us/cru/DIALIN-DEN-8856-1#c10373

  What does it mean to return two things: frames and message?

  Reply by qnguyen on 29 July 2021, 11:44
  > Removed the return of CAN frame list.

    Reply by Sean Nash on 30 July 2021, 10:35
    > RESOLVED.

----------------------------------------
File: dialin/utils/data_logger.py
Revision Comment by pmontazemi on 09 July 2021, 13:42 
https://devapps.diality.us/cru/DIALIN-DEN-8856-1#c10362

  Add TODO

  Reply by qnguyen on 19 July 2021, 09:31
  > Done.

    Reply by pmontazemi on 19 July 2021, 09:49
    > RESOLVED.

----------------------------------------
File: dialin/utils/singleton.py
Revision Comment by pmontazemi on 09 July 2021, 13:42 
https://devapps.diality.us/cru/DIALIN-DEN-8856-1#c10363

  Add TODO

  Reply by qnguyen on 19 July 2021, 09:31
  > Done.

    Reply by pmontazemi on 19 July 2021, 09:49
    > RESOLVED.

----------------------------------------
File: dialin/common/prs_defs.py
Revision Comment by Sean Nash on 20 July 2021, 13:11 
https://devapps.diality.us/cru/DIALIN-DEN-8856-1#c10372

  Aren't these alarm enums duplicates of the ones in
  alarm_defs.py?  Also, file name suggests these are pressure
  related definitions - so why are alarm definitions in here?

  Reply by qnguyen on 21 July 2021, 12:23
  > These are no definitions of these class inside alarm_defs.py
  > yet. I think this means PRS definitions rather than pressure.
  > [~bnematipour] Should these definitions be moved to another
  > file?

  Reply by Behrouz NematiPour on 29 July 2021, 17:47
  > In this filename, "prs" means "Product Requirement
  > Specification" and not "Pressure".
  > These values are defined in the PRS and are being used by UI
  > Simulator.

    Reply by Sean Nash on 30 July 2021, 10:36
    > RESOLVED.


---

ID: DIALIN-DEN-8856-1 https://devapps.diality.us/cru/DIALIN-DEN-8856-1

Title: DIALIN-DEN-8856_Sprint 47
Statement of Objectives:


State: Closed

Summary: 

Author: qnguyen
Moderator: qnguyen
Reviewers: (1 active, 2 completed*)
     Sean Nash   (*)
     pmontazemi   (*)
     Behrouz NematiPour