This is a list of all comments for DIALIN-DEN-9906-1.

Review Summary: No summary


----------------------------------------
File: dialin/dg/dialysate_generator.py
Revision Comment by Sean Nash on 28 October 2021, 08:34 
https://devapps.diality.us/cru/DIALIN-DEN-9906-1#c10999

  Move up for alphabetical order.  
  Also, need to add an import for this class at top of module.

  Reply by hnguyen on 28 October 2021, 10:32
  > Added from .flow_rate import DialysateFlowSensor and move up
  > alpha order

    Reply by Sean Nash on 28 October 2021, 13:10
    > RESOLVED.

----------------------------------------
File: dialin/dg/dialysate_flow_sensor.py
Revision Comment by Sean Nash on 28 October 2021, 08:36 
https://devapps.diality.us/cru/DIALIN-DEN-9906-1#c11001

  I think new modules should start copyright at current year -
  change 2019 to 2021.

  Reply by hnguyen on 28 October 2021, 09:16
  > Fixed.

    Reply by Sean Nash on 28 October 2021, 13:09
    > RESOLVED.

Revision Comment by Sean Nash on 28 October 2021, 08:36 
https://devapps.diality.us/cru/DIALIN-DEN-9906-1#c11000

  Update module name

  Reply by hnguyen on 28 October 2021, 09:20
  > Fixed.

    Reply by Sean Nash on 28 October 2021, 13:09
    > RESOLVED.

Revision Comment by Behrouz NematiPour on 06 November 2021, 12:43 
https://devapps.diality.us/cru/DIALIN-DEN-9906-1#c11136

  [~dnavaei] I assume we should not be worried about the authors
  and Bamboo copyright is enabled on Dialin, right?

  Reply by Dara Navaei on 06 November 2021, 20:01
  > Yes that is right. Please ignore the copyright section, the
  > Bamboo staging build will check all of those.

    Reply by Behrouz NematiPour on 06 November 2021, 22:03
    > RESOLVED.

Revision Comment by Sean Nash on 28 October 2021, 08:38 
https://devapps.diality.us/cru/DIALIN-DEN-9906-1#c11002

  This class does not appear to use DialinEnum.  Remove it.

  Reply by hnguyen on 28 October 2021, 09:22
  > Fixed

    Reply by Sean Nash on 28 October 2021, 13:09
    > RESOLVED.

Revision Comment by Sean Nash on 28 October 2021, 08:39 
https://devapps.diality.us/cru/DIALIN-DEN-9906-1#c11003

  Add brief for function description.  Add logger param.

  Reply by hnguyen on 28 October 2021, 10:00
  > Fixed

    Reply by Sean Nash on 28 October 2021, 13:08
    > RESOLVED.

Revision Comment by Sean Nash on 28 October 2021, 13:08 
https://devapps.diality.us/cru/DIALIN-DEN-9906-1#c11030

  Does init function return anything?

  Reply by Sean Nash on 11 November 2021, 09:42
  > I fixed this.

    Reply by Sean Nash on 11 November 2021, 09:43
    > RESOLVED.

Revision Comment by Sean Nash on 28 October 2021, 08:42 
https://devapps.diality.us/cru/DIALIN-DEN-9906-1#c11005

  Remove extra blank line.

  Reply by hnguyen on 28 October 2021, 09:32
  > Fixed

    Reply by Sean Nash on 28 October 2021, 13:08
    > RESOLVED.

Revision Comment by Sean Nash on 28 October 2021, 08:41 
https://devapps.diality.us/cru/DIALIN-DEN-9906-1#c11004

  You don't have a property called sensor to publish.  Change
  'sensor' to 'flow_rate'.

  Reply by hnguyen on 28 October 2021, 09:33
  > Fixed

    Reply by Sean Nash on 28 October 2021, 13:08
    > RESOLVED.

Revision Comment by Sean Nash on 28 October 2021, 08:44 
https://devapps.diality.us/cru/DIALIN-DEN-9906-1#c11006

  I think you need to change "flow" to "flow[0]" here.

  Reply by hnguyen on 28 October 2021, 09:39
  > Fixed

    Reply by Sean Nash on 28 October 2021, 13:07
    > RESOLVED.

Revision Comment by Sean Nash on 28 October 2021, 08:45 
https://devapps.diality.us/cru/DIALIN-DEN-9906-1#c11007

  Put float in parenthesis.

  Reply by hnguyen on 28 October 2021, 09:40
  > Fixed

    Reply by Sean Nash on 28 October 2021, 13:07
    > RESOLVED.

Revision Comment by Sean Nash on 28 October 2021, 08:59 
https://devapps.diality.us/cru/DIALIN-DEN-9906-1#c11008

  change to 50 ms.

  Reply by hnguyen on 28 October 2021, 09:41
  > Fixed

    Reply by Sean Nash on 28 October 2021, 13:06
    > RESOLVED.

Revision Comment by Sean Nash on 28 October 2021, 09:00 
https://devapps.diality.us/cru/DIALIN-DEN-9906-1#c11009

  This debug logging line is missing in flow override function
  above.

  Reply by hnguyen on 28 October 2021, 13:02
  > Fixed

    Reply by Sean Nash on 28 October 2021, 13:07
    > RESOLVED.


---

ID: DIALIN-DEN-9906-1 https://devapps.diality.us/cru/DIALIN-DEN-9906-1

Title: DIALIN-DEN-9906_HD Dev Flow Measurement Changes
Statement of Objectives:


State: Closed

Summary: 

Author: Sean Nash
Moderator: Sean Nash
Reviewers: (1 active, 2 completed*)
     hnguyen   (*)
     Dara Navaei   (*)
     Behrouz NematiPour