This is a list of all comments for DIALIN-DIAL-277-1.

Review Summary: No summary


----------------------------------------
File: dialin/dg/hd_proxy.py
Revision Comment by Sean Nash on 18 August 2023, 09:43 
https://devapps.diality.us/cru/DIALIN-DIAL-277-1#c18625

  Why does DG need this HD proxy command?

  Reply by Michael Garthwaite on 18 August 2023, 10:00
  > DG doesn't need this specifically but this is a HD proxy
  > command. V&V currently needs this to dismiss the prompt on
  > the UI screen. I think in the near future we should
  > reorganize Dialin sub modules. Maybe by overrides ( HD, DG, &
  > UI ) and proxy messages ( DG, HD, UI ).

    Reply by Sean Nash on 18 August 2023, 10:06
    > I see your point.  Issue is that we don't have a UI dialin
    > folder with an HD proxy class (where this function should
    > go).  
    > This command is not an HD proxy for DG so doesn't really
    > belong here.  
    > I would maybe put it in hd\buttons.

      Reply by Michael Garthwaite on 18 August 2023, 12:30
      > Moved to hd/buttons. Thanks!

        Reply by Sean Nash on 21 August 2023, 11:08
        > RESOLVED.


---

ID: DIALIN-DIAL-277-1 https://devapps.diality.us/cru/DIALIN-DIAL-277-1

Title: DIALIN-DIAL-277_Watchdog Override For DG
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (2 active, 2 completed*)
     Sean Nash   (*)
     Tiffany Mejia   (*)
     Dara Navaei
     Behrouz NematiPour