This is a list of all comments for HD-DEN-11098-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Modes/Prime.c Revision Comment by Sean Nash on 18 November 2021, 13:53 https://devapps.diality.us/cru/HD-DEN-11098-1#c11432 I would rename to something like prime dialyzer stop weight. Reply by hnguyen on 19 November 2021, 10:04 > Done Reply by Sean Nash on 02 December 2021, 10:32 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 24 November 2021, 14:37 https://devapps.diality.us/cru/HD-DEN-11098-1#c11452 Comment should change from 200 to 50. Reply by hnguyen on 02 December 2021, 10:43 > Updated this comment to > "Currently, we use 50.0 mL for testing. Remove this comment > and replace 50.0 with 10.0 before merge to develop branch" Reply by Sean Nash on 04 January 2022, 10:19 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 30 December 2021, 09:55 https://devapps.diality.us/cru/HD-DEN-11098-1#c11587 Recommend moving this rate to be with the others above. Reply by hnguyen on 03 January 2022, 11:21 > Done. Reply by Sean Nash on 04 January 2022, 10:06 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 13 December 2021, 11:16 https://devapps.diality.us/cru/HD-DEN-11098-1#c11502 Why is this commented out? Reply by hnguyen on 13 December 2021, 13:47 > Replaced by primeDialysateDialyzerTimeLimit because this > variable is dynamic and based on the type of dialyzer. Reply by Sean Nash on 04 January 2022, 10:15 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 13 December 2021, 11:22 https://devapps.diality.us/cru/HD-DEN-11098-1#c11503 Should be 120 mL divided by 300 mL/min times 60 sec/min = 24 seconds. Reply by hnguyen on 13 December 2021, 13:50 > Fixed. Reply by Sean Nash on 04 January 2022, 10:15 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 18 November 2021, 14:08 https://devapps.diality.us/cru/HD-DEN-11098-1#c11434 Make it clearer that this is for prime dialyzer state. Reply by hnguyen on 19 November 2021, 10:10 > Done Reply by Sean Nash on 02 December 2021, 10:31 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 18 November 2021, 14:08 https://devapps.diality.us/cru/HD-DEN-11098-1#c11433 Dialyzer is spelled with a "z" not "s". Reply by hnguyen on 19 November 2021, 10:04 > Done Reply by Sean Nash on 02 December 2021, 10:32 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 13 December 2021, 11:27 https://devapps.diality.us/cru/HD-DEN-11098-1#c11504 Do we need separate start time variables? These are not used at same time - consider consolidating into a single variable. Reply by hnguyen on 13 December 2021, 17:32 > Yes, we could use a single variable as the start time in all > the pre-treatment states Reply by Sean Nash on 04 January 2022, 10:14 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 24 November 2021, 14:45 https://devapps.diality.us/cru/HD-DEN-11098-1#c11453 Should only set this to true when we know we will accept request. Reply by hnguyen on 02 December 2021, 10:38 > Fixed. Reply by Sean Nash on 04 January 2022, 10:17 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 13 December 2021, 11:32 https://devapps.diality.us/cru/HD-DEN-11098-1#c11505 Add blank line between these lines. Reply by hnguyen on 13 December 2021, 16:47 > Done. Reply by Sean Nash on 04 January 2022, 10:13 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 13 December 2021, 11:33 https://devapps.diality.us/cru/HD-DEN-11098-1#c11506 Add blank line between these two lines. Reply by hnguyen on 13 December 2021, 16:47 > Done Reply by Sean Nash on 04 January 2022, 10:13 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 18 November 2021, 14:10 https://devapps.diality.us/cru/HD-DEN-11098-1#c11436 I think this needs to be closed or saline will not be forced across dialyzer into dialysate flow path. Reply by hnguyen on 19 November 2021, 10:04 > Fixed Reply by Sean Nash on 02 December 2021, 10:31 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 18 November 2021, 16:18 https://devapps.diality.us/cru/HD-DEN-11098-1#c11440 This might be reservoir 1 - there is a pre-treatment reservoir mgmt function handling this - check to see which reservoir is active at beginning of prime here. Reply by hnguyen on 19 November 2021, 10:06 > I believe reservoir 2 is used. > > static PRE_TREATMENT_RESERVOIR_MGMT_STATE_T > handlePreTreatmentReservoirMgmtStartState( void ) > { > PRE_TREATMENT_RESERVOIR_MGMT_STATE_T state = > PRE_TREATMENT_RESERVOIR_MGMT_START_STATE; > > if ( TRUE == fillReservoirOneStartRequested ) > { > fillReservoirOneStartRequested = FALSE; > state = PRE_TREATMENT_RESERVOIR_MGMT_DRAIN_CMD_STATE; > cmdSetDGActiveReservoir( DG_RESERVOIR_2 ); > } > > return state; > } Reply by Sean Nash on 02 December 2021, 10:30 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 18 November 2021, 14:18 https://devapps.diality.us/cru/HD-DEN-11098-1#c11439 Why reset start time here? Reply by hnguyen on 19 November 2021, 10:07 > Fixed Reply by Sean Nash on 02 December 2021, 10:31 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 23 November 2021, 09:19 https://devapps.diality.us/cru/HD-DEN-11098-1#c11448 Move this line to when prime dialyzer state is completed before we go to wet self tests. Reply by hnguyen on 23 November 2021, 09:30 > Fixed. Before transition from dialyzer state to wet > selftests state, the VDO pump should be stopped. Reply by Sean Nash on 23 November 2021, 09:51 > You can remove this line here. That pump has not yet been > run. Reply by Sean Nash on 02 December 2021, 10:30 > RESOLVED in CODE WALKTHROUGH. Revision Comment by hnguyen on 23 November 2021, 09:58 https://devapps.diality.us/cru/HD-DEN-11098-1#c11451 Done. Reply by Dara Navaei on 19 October 2023, 08:00 > RESOLVED in CODE WALKTHROUGH Revision Comment by Sean Nash on 13 December 2021, 14:54 https://devapps.diality.us/cru/HD-DEN-11098-1#c11510 Please put declarations at top of scope (i.e. just below the '{' above). Reply by hnguyen on 13 December 2021, 16:52 > Done Reply by Sean Nash on 04 January 2022, 10:13 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 13 December 2021, 14:56 https://devapps.diality.us/cru/HD-DEN-11098-1#c11511 If skipping priming, would we even get here? Reply by hnguyen on 04 January 2022, 09:40 > Yes, see > #ifdef SKIP_PRIMING > currentPrimeState = > HD_PRIME_RESERVOIR_ONE_FILL_COMPLETE_STATE; > #else > currentPrimeState = > HD_PRIME_WAIT_FOR_USER_START_STATE; > #endif Reply by Sean Nash on 04 January 2022, 10:12 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 13 December 2021, 14:59 https://devapps.diality.us/cru/HD-DEN-11098-1#c11512 This start time was last set in setup function - quite some time ago. So this will have immediately timed out the first time we get here. I think this still works though. Reply by hnguyen on 13 December 2021, 16:59 > No, loadcellSteadyVolumeStartTime was last set when the > primeDialysateDialyzerTimeLimit has just expired. Reply by Sean Nash on 04 January 2022, 10:10 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 13 December 2021, 16:01 https://devapps.diality.us/cru/HD-DEN-11098-1#c11513 Add blank line between declarations and code. Reply by hnguyen on 13 December 2021, 17:09 > Done Reply by Sean Nash on 04 January 2022, 10:08 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 30 December 2021, 09:49 https://devapps.diality.us/cru/HD-DEN-11098-1#c11585 Make 0.5 a #define. Reply by hnguyen on 03 January 2022, 11:37 > Done. Reply by Sean Nash on 04 January 2022, 10:06 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 13 December 2021, 16:10 https://devapps.diality.us/cru/HD-DEN-11098-1#c11515 Recommend just setting up pumps and valves in this function rather than calling another function. Reply by hnguyen on 13 December 2021, 17:13 > Done Reply by Sean Nash on 04 January 2022, 10:08 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 13 December 2021, 16:13 https://devapps.diality.us/cru/HD-DEN-11098-1#c11518 This start time probably needs a new name to better describe what it's doing. Reply by hnguyen on 13 December 2021, 17:31 > Replaced "loadcellSteadyVolumeStartTime" with > "steadyVolumeSamplingStartTime" Reply by Sean Nash on 04 January 2022, 10:07 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 30 December 2021, 09:51 https://devapps.diality.us/cru/HD-DEN-11098-1#c11586 STEADY_VOLUME_COUNT_SEC is a number of seconds of stability indicating volume is steady. This only works because sampling time above is once per second. If somebody changes the sampling time, this condition will not be right. Reply by hnguyen on 03 January 2022, 11:39 > Done. Reply by Sean Nash on 04 January 2022, 10:06 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: AlarmDefs.h Revision Comment by Sean Nash on 30 December 2021, 09:43 https://devapps.diality.us/cru/HD-DEN-11098-1#c11584 Can we please use available alarm IDs above before adding a new one? Reply by Dara Navaei on 30 December 2021, 10:00 > Done. Reply by hnguyen on 03 January 2022, 11:41 > Dara, did you add this alarm? Reply by Sean Nash on 04 January 2022, 10:07 > RESOLVED in CODE WALKTHROUGH. --- ID: HD-DEN-11098-1 https://devapps.diality.us/cru/HD-DEN-11098-1 Title: HD-DEN-11098_Implement HD Pre Treatment Mode Update Statement of Objectives: State: Closed Summary: Author: hnguyen Moderator: hnguyen Reviewers: (0 active, 2 completed*) Sean Nash (*) Dara Navaei (*)