This is a list of all comments for HD-DEN-12121-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/Rinseback.h
Revision Comment by Dara Navaei on 06 March 2022, 20:38 
https://devapps.diality.us/cru/HD-DEN-12121-1#c12403

  This should be a BOOL since you are suing this as a boolean.

  Reply by Michael Garthwaite on 09 March 2022, 12:16
  > Fixed. Thanks!

    Reply by Dara Navaei on 09 March 2022, 14:31
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/SystemCommMessages.c
Revision Comment by Dara Navaei on 06 March 2022, 20:43 
https://devapps.diality.us/cru/HD-DEN-12121-1#c12404

  Why was this include removed? Do you not need it for the
  treatment parameters commands?

  Reply by Michael Garthwaite on 09 March 2022, 12:15
  > Double #include. It is already written in
  > SystemCommMessages.h

    Reply by Dara Navaei on 09 March 2022, 14:31
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: MsgDefs.h
Revision Comment by Dara Navaei on 06 March 2022, 20:57 
https://devapps.diality.us/cru/HD-DEN-12121-1#c12410

  Align the comment.

  Reply by Michael Garthwaite on 09 March 2022, 11:50
  > Fixed. Changed Msg_id for this cmd to 0xA008 to prevent
  > conflicts.

    Reply by Dara Navaei on 09 March 2022, 14:31
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-12121-1 https://devapps.diality.us/cru/HD-DEN-12121-1

Title: HD-DEN-12121_SW Dev Sprint 65
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (1 active, 2 completed*)
     Sean Nash   (*)
     Dara Navaei   (*)
     hnguyen