This is a list of all comments for HD-DEN-12931-2. Review Summary: No summary ---------------------------------------- File: firmware/App/Controllers/BloodLeak.c Revision Comment by Sean Nash on 12 July 2022, 15:13 https://devapps.diality.us/cru/HD-DEN-12931-2#c13281 Add blank line before return. Reply by Dara Navaei on 03 August 2022, 20:09 > Done. Reply by Sean Nash on 04 August 2022, 15:15 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 12 July 2022, 15:16 https://devapps.diality.us/cru/HD-DEN-12931-2#c13285 Update input/outputs throughout. Reply by Dara Navaei on 03 August 2022, 20:08 > Done. Reply by Sean Nash on 04 August 2022, 15:15 > RESOLVED in CODE WALKTHROUGH. Revision Comment by wbracken on 18 July 2022, 12:14 https://devapps.diality.us/cru/HD-DEN-12931-2#c13300 Is this supposed to have been removed. Reply by Dara Navaei on 03 August 2022, 20:03 > Blood leak is still in development. This will be addressed in > DEN-13460. Reply by Dara Navaei on 04 August 2022, 15:30 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 12 July 2022, 15:19 https://devapps.diality.us/cru/HD-DEN-12931-2#c13286 Looks like exit normal request (below) will take precedence over this request. Is that intended? Reply by Dara Navaei on 03 August 2022, 20:07 > I thought exiting the normal state is the last request we > want to check after making sure nothing else is requested. Reply by Sean Nash on 04 August 2022, 15:22 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 12 July 2022, 15:20 https://devapps.diality.us/cru/HD-DEN-12931-2#c13287 indent of cases looks too small. Reply by Dara Navaei on 03 August 2022, 20:06 > Done. Reply by Sean Nash on 04 August 2022, 15:17 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/SyringePump.c Revision Comment by wbracken on 18 July 2022, 13:00 https://devapps.diality.us/cru/HD-DEN-12931-2#c13302 Need #define for minimum vRef Reply by Dara Navaei on 03 August 2022, 20:02 > Done. Reply by Dara Navaei on 04 August 2022, 15:29 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModePreTreat.c Revision Comment by wbracken on 18 July 2022, 14:47 https://devapps.diality.us/cru/HD-DEN-12931-2#c13304 Check NEARLY_ZERO #define. Value should be 0.00000001F. I believe previous review commented indicated that all floating point #defines should have "F" at the end. Reply by Sean Nash on 21 July 2022, 21:03 > F has been added. Reply by Dara Navaei on 04 August 2022, 15:27 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/SystemComm.c Revision Comment by Sean Nash on 22 July 2022, 08:27 https://devapps.diality.us/cru/HD-DEN-12931-2#c13314 Why removed? I thought we needed this for VC? Reply by Dara Navaei on 03 August 2022, 19:47 > This can be reached in VC because it is not in a for loop. Reply by Sean Nash on 04 August 2022, 15:10 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 22 July 2022, 08:28 https://devapps.diality.us/cru/HD-DEN-12931-2#c13315 Why removed? Reply by Dara Navaei on 03 August 2022, 19:48 > This can be reached in VC since it is not in a for loop. Reply by Sean Nash on 04 August 2022, 15:09 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/Fans.c Revision Comment by Sean Nash on 21 July 2022, 20:49 https://devapps.diality.us/cru/HD-DEN-12931-2#c13307 Can we remove this now? Reply by Dara Navaei on 03 August 2022, 19:56 > Done. Reply by Sean Nash on 04 August 2022, 15:12 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/OperationModes.c Revision Comment by Michael Garthwaite on 07 July 2022, 13:28 https://devapps.diality.us/cru/HD-DEN-12931-2#c13274 Do we want to keep this debug & sprintf? Reply by Sean Nash on 21 July 2022, 21:01 > No. Code removed. Reply by Dara Navaei on 03 August 2022, 20:10 > Removed the code. Reply by Michael Garthwaite on 04 August 2022, 15:01 > RESOLVED CODE IN WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/Switches.c Revision Comment by Sean Nash on 21 July 2022, 20:50 https://devapps.diality.us/cru/HD-DEN-12931-2#c13308 Remove blank line. Reply by Dara Navaei on 03 August 2022, 19:55 > Done. Reply by Sean Nash on 04 August 2022, 15:12 > RESOLVED in CODE WALKTHROUGH. Revision Comment by wbracken on 18 July 2022, 12:55 https://devapps.diality.us/cru/HD-DEN-12931-2#c13301 Is the data being published elsewhere? Reply by Sean Nash on 21 July 2022, 20:52 > Yes, at bottom of exec function above. Reply by Dara Navaei on 04 August 2022, 15:30 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModePostTreat.c Revision Comment by Sean Nash on 21 July 2022, 20:58 https://devapps.diality.us/cru/HD-DEN-12931-2#c13310 If no actions handled in this mode, add a comment saying so. Reply by Sean Nash on 04 August 2022, 15:17 > RESOLVED in CODE WALKTHROUGH. Revision Comment by wbracken on 18 July 2022, 14:42 https://devapps.diality.us/cru/HD-DEN-12931-2#c13303 SW_CONFIG_ENABLE_VALUE should be first in the conditional. Reply by Dara Navaei on 03 August 2022, 19:57 > We only do that if we do the == comparison. This is to make > sure the compiler errors out if only one = is put instead of > ==. Reply by Dara Navaei on 04 August 2022, 15:28 > RESOLVED in CODE WALKTHROUGH. --- ID: HD-DEN-12931-2 https://devapps.diality.us/cru/HD-DEN-12931-2 Title: HD-DEN-12931_DG HD Dev HD DG Dvt Update Statement of Objectives: State: Closed Summary: Author: Dara Navaei Moderator: Dara Navaei Reviewers: (1 active, 3 completed*) Sean Nash (*) Michael Garthwaite (*) wbracken (*) Dong Nguyen