This is a list of all comments for HD-DEN-13167-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/Dialysis.c
Revision Comment by Sean Nash on 22 July 2022, 13:17 
https://devapps.diality.us/cru/HD-DEN-13167-1#c13329

  Better name is reservoir use cycle steady sample points (during
  treatment, but we're in Dialysis.c here so treatment can be
  inferred).

  Reply by Darren Cox on 27 July 2022, 10:12
  > Modified names

    Reply by Sean Nash on 16 August 2022, 11:14
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 22 July 2022, 13:26 
https://devapps.diality.us/cru/HD-DEN-13167-1#c13330

  I though cycle was an enum (start/final), not a boolean.
  Should we be looking for final (not TRUE)?

  Reply by Darren Cox on 27 July 2022, 10:12
  > Fixed.  Good catch.  started with boolean, but changed to
  > enum.

    Reply by Sean Nash on 16 August 2022, 11:13
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 22 July 2022, 13:29 
https://devapps.diality.us/cru/HD-DEN-13167-1#c13331

  Can we remove this now?

  Reply by Darren Cox on 27 July 2022, 10:13
  > Removed.

    Reply by Sean Nash on 16 August 2022, 11:13
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-13167-1 https://devapps.diality.us/cru/HD-DEN-13167-1

Title: HD-DEN-13167_SW Dev Sprint 74 Darren
Statement of Objectives:


State: Closed

Summary: 

Author: Darren Cox
Moderator: Darren Cox
Reviewers: (3 active, 2 completed*)
     Sean Nash   (*)
     wbracken   (*)
     Michael Garthwaite
     Dara Navaei
     Dong Nguyen