This is a list of all comments for HD-DEN-13460-2. Review Summary: No summary ---------------------------------------- File: firmware/App/Controllers/BloodLeak.c Revision Comment by wbracken on 30 August 2022, 11:32 https://devapps.diality.us/cru/HD-DEN-13460-2#c13605 Update function header. Reply by Dara Navaei on 01 September 2022, 16:35 > Done. Reply by wbracken on 12 September 2022, 16:16 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 30 August 2022, 12:12 https://devapps.diality.us/cru/HD-DEN-13460-2#c13606 Update function header. Reply by Dara Navaei on 01 September 2022, 16:34 > Done. Reply by wbracken on 12 September 2022, 16:16 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 30 August 2022, 12:16 https://devapps.diality.us/cru/HD-DEN-13460-2#c13607 Update function header. Reply by Dara Navaei on 01 September 2022, 16:33 > Done. Reply by Dara Navaei on 19 October 2023, 09:20 > RESOLVED in CODE WALKTHROUGH Revision Comment by wbracken on 30 August 2022, 12:17 https://devapps.diality.us/cru/HD-DEN-13460-2#c13608 Update function header. Reply by Dara Navaei on 01 September 2022, 16:31 > Done. Reply by wbracken on 12 September 2022, 16:16 > RESOLVED IN CODE WALKTHROUGH√ Revision Comment by wbracken on 30 August 2022, 12:19 https://devapps.diality.us/cru/HD-DEN-13460-2#c13609 Update function header. Reply by Dara Navaei on 01 September 2022, 16:29 > Done. Reply by wbracken on 12 September 2022, 16:16 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 30 August 2022, 12:27 https://devapps.diality.us/cru/HD-DEN-13460-2#c13610 Update function header. Reply by Dara Navaei on 22 September 2022, 10:12 > Done. Reply by wbracken on 22 September 2022, 15:39 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 30 August 2022, 12:28 https://devapps.diality.us/cru/HD-DEN-13460-2#c13611 Remove code. Reply by Dara Navaei on 31 August 2022, 14:57 > Done. Reply by wbracken on 12 September 2022, 16:15 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 30 August 2022, 12:30 https://devapps.diality.us/cru/HD-DEN-13460-2#c13612 Update function header. Reply by Dara Navaei on 22 September 2022, 11:09 > Done. Reply by wbracken on 22 September 2022, 15:36 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 30 August 2022, 12:32 https://devapps.diality.us/cru/HD-DEN-13460-2#c13613 Update function header. Reply by Dara Navaei on 01 September 2022, 11:33 > Done. Reply by wbracken on 12 September 2022, 16:14 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 30 August 2022, 12:33 https://devapps.diality.us/cru/HD-DEN-13460-2#c13614 Update function header. Reply by Dara Navaei on 01 September 2022, 10:35 > Done. Reply by wbracken on 12 September 2022, 16:15 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 30 August 2022, 12:36 https://devapps.diality.us/cru/HD-DEN-13460-2#c13615 Update header function. Reply by Dara Navaei on 01 September 2022, 10:25 > Done. Reply by wbracken on 12 September 2022, 16:13 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 30 August 2022, 12:38 https://devapps.diality.us/cru/HD-DEN-13460-2#c13616 Update function header. Reply by Dara Navaei on 01 September 2022, 10:17 > Done. Reply by wbracken on 12 September 2022, 16:13 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Controllers/DialOutFlow.c Revision Comment by wbracken on 30 August 2022, 12:46 https://devapps.diality.us/cru/HD-DEN-13460-2#c13618 Move to left margin? Several occurrences. Reply by Dara Navaei on 01 September 2022, 10:14 > Done. Reply by wbracken on 12 September 2022, 16:13 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/HDCommon.h Revision Comment by wbracken on 30 August 2022, 13:52 https://devapps.diality.us/cru/HD-DEN-13460-2#c13638 Remove TODO. Reply by Dara Navaei on 31 August 2022, 09:49 > This is still a TODO. We are trying to avoid a switch for the > batteries overall. Reply by wbracken on 12 September 2022, 16:07 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Modes/SelfTests.c Revision Comment by wbracken on 30 August 2022, 13:26 https://devapps.diality.us/cru/HD-DEN-13460-2#c13629 Should both bolusVol and hebRate need to be valid? Can you have hepRate set and no bolus? Reply by Dara Navaei on 14 September 2022, 11:06 > We can have either of the values set without the other value > set. Reply by wbracken on 22 September 2022, 15:39 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 30 August 2022, 13:28 https://devapps.diality.us/cru/HD-DEN-13460-2#c13630 Update function header. Reply by Dara Navaei on 31 August 2022, 14:18 > Done. Reply by wbracken on 12 September 2022, 16:10 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 30 August 2022, 13:30 https://devapps.diality.us/cru/HD-DEN-13460-2#c13631 Update function header. Reply by Dara Navaei on 31 August 2022, 14:16 > Done. Reply by wbracken on 22 September 2022, 15:38 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Modes/ModeFault.c Revision Comment by wbracken on 30 August 2022, 13:17 https://devapps.diality.us/cru/HD-DEN-13460-2#c13628 Update function header. Reply by Dara Navaei on 31 August 2022, 21:39 > Done. Reply by wbracken on 12 September 2022, 16:10 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Services/SystemComm.c Revision Comment by wbracken on 30 August 2022, 13:43 https://devapps.diality.us/cru/HD-DEN-13460-2#c13635 Update function header. Reply by Dara Navaei on 31 August 2022, 21:31 > This function header is up to date. Reply by wbracken on 12 September 2022, 16:08 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 30 August 2022, 13:45 https://devapps.diality.us/cru/HD-DEN-13460-2#c13636 Update function header. recvmsg Reply by Dara Navaei on 31 August 2022, 21:29 > Done. Reply by wbracken on 12 September 2022, 16:08 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Tasks/TaskPriority.c Revision Comment by Sean Nash on 16 September 2022, 10:28 https://devapps.diality.us/cru/HD-DEN-13460-2#c13780 Remove extra blank line. Reply by Dara Navaei on 22 September 2022, 11:12 > Done. Reply by Sean Nash on 22 September 2022, 15:47 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/SyringePump.c Revision Comment by Sean Nash on 08 September 2022, 09:57 https://devapps.diality.us/cru/HD-DEN-13460-2#c13723 Keep this blank line. Separate declarations from code. Reply by Dara Navaei on 22 September 2022, 10:54 > Done. Reply by Sean Nash on 22 September 2022, 15:49 > RESOLVED in CODE WALKTHROUGH. Revision Comment by wbracken on 30 August 2022, 12:52 https://devapps.diality.us/cru/HD-DEN-13460-2#c13619 Update function header. Reply by Dara Navaei on 01 September 2022, 10:13 > Done. Reply by wbracken on 12 September 2022, 16:14 > RESOLVED IN CODE WALKTHROUGH Revision Comment by Michael Garthwaite on 01 September 2022, 14:33 https://devapps.diality.us/cru/HD-DEN-13460-2#c13694 remove blank line Reply by Dara Navaei on 01 September 2022, 16:36 > Done. Reply by Michael Garthwaite on 12 September 2022, 16:18 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Controllers/Valves.c Revision Comment by wbracken on 30 August 2022, 13:00 https://devapps.diality.us/cru/HD-DEN-13460-2#c13622 Remove TODO Reply by Dara Navaei on 01 September 2022, 10:09 > Done. Reply by wbracken on 12 September 2022, 16:11 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 30 August 2022, 13:01 https://devapps.diality.us/cru/HD-DEN-13460-2#c13623 valveStatus is both input/output. Reply by Dara Navaei on 01 September 2022, 10:08 > Done. Reply by wbracken on 12 September 2022, 16:12 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Controllers/DGInterface.c Revision Comment by Darren Cox on 12 September 2022, 11:25 https://devapps.diality.us/cru/HD-DEN-13460-2#c13731 Should initialization use 0.0F? Reply by Dara Navaei on 22 September 2022, 10:55 > These variables will be deleted. Reply by Darren Cox on 22 September 2022, 15:31 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 30 August 2022, 22:47 https://devapps.diality.us/cru/HD-DEN-13460-2#c13643 Is the "F" required after floating point constant? Should be consistent. Reply by Dara Navaei on 31 August 2022, 09:49 > True we have to be consistent. Added "F". Reply by wbracken on 12 September 2022, 16:07 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Modes/BloodPrime.c Revision Comment by wbracken on 30 August 2022, 13:12 https://devapps.diality.us/cru/HD-DEN-13460-2#c13627 Remove commented code. Reply by Dara Navaei on 31 August 2022, 14:22 > Added a TODO to the commented code. Reply by wbracken on 12 September 2022, 16:11 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Controllers/Temperatures.c Revision Comment by wbracken on 30 August 2022, 12:55 https://devapps.diality.us/cru/HD-DEN-13460-2#c13620 Update function header. Reply by Dara Navaei on 01 September 2022, 10:12 > Done. Reply by Dara Navaei on 19 October 2023, 09:22 > RESOLVED in CODE WALKTHROUGH Reply by wbracken on 12 September 2022, 16:12 > RESOLVED IN CODE WALKTHROUGH Reply by Dara Navaei on 19 October 2023, 09:42 > RESOLVED in CODE WALKTHROUGH Revision Comment by wbracken on 30 August 2022, 12:56 https://devapps.diality.us/cru/HD-DEN-13460-2#c13621 Update function header. Reply by Dara Navaei on 01 September 2022, 10:11 > Done. Reply by Dara Navaei on 19 October 2023, 09:42 > RESOLVED in CODE WALKTHROUGH Revision Comment by Michael Garthwaite on 01 September 2022, 14:37 https://devapps.diality.us/cru/HD-DEN-13460-2#c13695 More of a caution than an explicit fix. Dong's S77 branch has some of the changes that are reflected here. He also has the more recent commit. Be careful when both of you merge your branches. Reply by Dara Navaei on 01 September 2022, 16:37 > Thanks for the reminder. Reply by Michael Garthwaite on 12 September 2022, 16:18 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Services/Reservoirs.c Revision Comment by wbracken on 30 August 2022, 13:41 https://devapps.diality.us/cru/HD-DEN-13460-2#c13634 Update function header. reservoirState. Reply by Dara Navaei on 31 August 2022, 14:14 > Done. Reply by wbracken on 12 September 2022, 16:08 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 31 August 2022, 11:38 https://devapps.diality.us/cru/HD-DEN-13460-2#c13646 Remove blank line. Reply by Dara Navaei on 31 August 2022, 14:14 > Done. Reply by wbracken on 12 September 2022, 16:06 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Drivers/Battery.c Revision Comment by wbracken on 30 August 2022, 13:08 https://devapps.diality.us/cru/HD-DEN-13460-2#c13624 Update function header. Reply by Dara Navaei on 01 September 2022, 09:34 > Done. Reply by wbracken on 12 September 2022, 16:11 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 30 August 2022, 13:11 https://devapps.diality.us/cru/HD-DEN-13460-2#c13625 Update function header. Reply by Dara Navaei on 01 September 2022, 09:27 > Done. Reply by wbracken on 12 September 2022, 16:11 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 30 August 2022, 13:11 https://devapps.diality.us/cru/HD-DEN-13460-2#c13626 Update function header. Reply by Dara Navaei on 31 August 2022, 21:41 > Done. Reply by wbracken on 12 September 2022, 16:11 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Controllers/DialInFlow.c Revision Comment by wbracken on 30 August 2022, 12:45 https://devapps.diality.us/cru/HD-DEN-13460-2#c13617 Should be at left margin? Reply by Dara Navaei on 01 September 2022, 10:15 > Done. Reply by wbracken on 12 September 2022, 16:13 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Controllers/Voltages.c Revision Comment by Sean Nash on 16 September 2022, 10:12 https://devapps.diality.us/cru/HD-DEN-13460-2#c13777 Keep blank line. Reply by Dara Navaei on 22 September 2022, 11:10 > Done. Reply by Sean Nash on 22 September 2022, 15:49 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 16 September 2022, 10:14 https://devapps.diality.us/cru/HD-DEN-13460-2#c13778 Keep blank line. Reply by Dara Navaei on 22 September 2022, 11:10 > Done. Reply by Sean Nash on 22 September 2022, 15:49 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/OperationModes.h Revision Comment by Sean Nash on 16 September 2022, 10:22 https://devapps.diality.us/cru/HD-DEN-13460-2#c13779 I don't see this function implemented in c file. Reply by Dara Navaei on 22 September 2022, 11:11 > It is implemented. Reply by Sean Nash on 22 September 2022, 15:49 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Services/AlarmMgmt.c Revision Comment by wbracken on 30 August 2022, 13:37 https://devapps.diality.us/cru/HD-DEN-13460-2#c13632 Update function header. Reply by Dara Navaei on 31 August 2022, 21:34 > Done. Reply by wbracken on 12 September 2022, 16:09 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 30 August 2022, 13:38 https://devapps.diality.us/cru/HD-DEN-13460-2#c13633 Update function header. Reply by Dara Navaei on 31 August 2022, 14:15 > Done. Reply by wbracken on 12 September 2022, 16:09 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Services/CommBuffers.c Revision Comment by Michael Garthwaite on 31 August 2022, 16:22 https://devapps.diality.us/cru/HD-DEN-13460-2#c13673 Does this need to be changed on the DG's side as well? Reply by Dara Navaei on 22 September 2022, 10:52 > The buffer has been increased in the DEN-13903. Reply by Sean Nash on 22 September 2022, 15:50 > RESOLVED in CODE WALKTHROUGH. --- ID: HD-DEN-13460-2 https://devapps.diality.us/cru/HD-DEN-13460-2 Title: HD-DEN-13460_DG HD Dev HD DG Dvt Update Part 2 Statement of Objectives: State: Closed Summary: Author: Dara Navaei Moderator: Dara Navaei Reviewers: (1 active, 3 completed*) Sean Nash (*) wbracken (*) Darren Cox (*) Michael Garthwaite