This is a list of all comments for HD-DEN-13801-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Drivers/Battery.c Revision Comment by Darren Cox on 19 September 2022, 15:03 https://devapps.diality.us/cru/HD-DEN-13801-1#c13813 Last value is 0, should be 0.0. Do they need to be 0.0F? Reply by Sean Nash on 13 October 2022, 14:28 > Last value is U32 (this is a structure, not an array). "F" > suffix is not required for typed assignments. Required for > potentially untyped #defines /expressions / ... Reply by Dara Navaei on 19 October 2023, 09:15 > RESOLVED in CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Modes/SelfTests.c Revision Comment by Sean Nash on 28 October 2022, 09:34 https://devapps.diality.us/cru/HD-DEN-13801-1#c14647 Comment doesn't match time. Reply by Michael Garthwaite on 28 October 2022, 13:32 > Fixed... but i dont recall making this change to this value Reply by Sean Nash on 28 October 2022, 15:07 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 28 October 2022, 09:35 https://devapps.diality.us/cru/HD-DEN-13801-1#c14648 Needs doxygen comment. Reply by Michael Garthwaite on 28 October 2022, 13:31 > Fixed. Thanks! Reply by Sean Nash on 28 October 2022, 15:07 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 28 October 2022, 09:35 https://devapps.diality.us/cru/HD-DEN-13801-1#c14649 Align comment. Reply by Michael Garthwaite on 28 October 2022, 13:31 > Fixed. Thanks! Reply by Sean Nash on 28 October 2022, 15:07 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 28 October 2022, 09:35 https://devapps.diality.us/cru/HD-DEN-13801-1#c14650 Add doxygen comment. Reply by Michael Garthwaite on 28 October 2022, 13:31 > Fixed. Thanks! Reply by Sean Nash on 28 October 2022, 15:07 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 28 October 2022, 09:37 https://devapps.diality.us/cru/HD-DEN-13801-1#c14651 Remove blank line. Reply by Michael Garthwaite on 28 October 2022, 13:31 > Fixed. Thanks! Reply by Sean Nash on 28 October 2022, 15:06 > RESOLVED in CODE WALKTHROUGH. Revision Comment by wbracken on 30 September 2022, 14:38 https://devapps.diality.us/cru/HD-DEN-13801-1#c14076 Update function header. Reply by Michael Garthwaite on 21 October 2022, 14:17 > Fixed. Thanks! Reply by wbracken on 21 October 2022, 15:58 > RESOLVED IN CODE WALKTHROUGH Revision Comment by Sean Nash on 28 October 2022, 09:41 https://devapps.diality.us/cru/HD-DEN-13801-1#c14653 Restore blank line between functions. Reply by Michael Garthwaite on 28 October 2022, 13:31 > Fixed. Thanks! Reply by Sean Nash on 28 October 2022, 14:46 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 28 October 2022, 09:40 https://devapps.diality.us/cru/HD-DEN-13801-1#c14652 Remove blank line. Reply by Michael Garthwaite on 28 October 2022, 13:31 > Fixed. Thanks! Reply by Sean Nash on 28 October 2022, 15:06 > RESOLVED in CODE WALKTHROUGH. Revision Comment by wbracken on 19 October 2022, 10:49 https://devapps.diality.us/cru/HD-DEN-13801-1#c14531 Update function header. Reply by Michael Garthwaite on 21 October 2022, 14:17 > Fixed. Thanks! Reply by wbracken on 21 October 2022, 15:58 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Controllers/PresOccl.c Revision Comment by Darren Cox on 19 September 2022, 15:01 https://devapps.diality.us/cru/HD-DEN-13801-1#c13812 Magic number 1500. Give an explanation or define constant elsewhere. Reply by Michael Garthwaite on 21 October 2022, 14:16 > Fixed. Thanks! Reply by Sean Nash on 25 October 2022, 12:43 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModePreTreat.c Revision Comment by Sean Nash on 28 October 2022, 09:47 https://devapps.diality.us/cru/HD-DEN-13801-1#c14655 Add doxygen comment. Reply by Michael Garthwaite on 28 October 2022, 13:31 > Fixed. Thanks! Reply by Sean Nash on 28 October 2022, 14:46 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 21 October 2022, 11:38 https://devapps.diality.us/cru/HD-DEN-13801-1#c14545 Remove extra blank line. Reply by Michael Garthwaite on 21 October 2022, 14:17 > Fixed. Thanks! Reply by Sean Nash on 21 October 2022, 14:22 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 21 October 2022, 11:39 https://devapps.diality.us/cru/HD-DEN-13801-1#c14546 Remove extra blank line. Reply by Michael Garthwaite on 21 October 2022, 14:17 > Fixed. Thanks! Reply by Sean Nash on 21 October 2022, 14:25 > RESOLVED in CODE WALKTHROUGH. Revision Comment by wbracken on 28 October 2022, 12:06 https://devapps.diality.us/cru/HD-DEN-13801-1#c14665 Remove blank line. Reply by Michael Garthwaite on 28 October 2022, 13:30 > Fixed. Thanks! Reply by wbracken on 28 October 2022, 14:41 > RESOLVED IN CODE WALKTHROUGH. Revision Comment by Sean Nash on 21 October 2022, 11:41 https://devapps.diality.us/cru/HD-DEN-13801-1#c14547 These inits are redundant as initPreTreatmentMode() is called just below which resets these flags already. Reply by Michael Garthwaite on 21 October 2022, 14:16 > Fixed. Thanks! Reply by Sean Nash on 21 October 2022, 14:23 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 28 October 2022, 09:48 https://devapps.diality.us/cru/HD-DEN-13801-1#c14656 Remove commented out line of code. Reply by Michael Garthwaite on 28 October 2022, 13:31 > Fixed. Thanks! Reply by Sean Nash on 28 October 2022, 14:46 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 28 October 2022, 09:48 https://devapps.diality.us/cru/HD-DEN-13801-1#c14657 Remove commented out line of code. Reply by Michael Garthwaite on 28 October 2022, 13:30 > Fixed. Thanks! Reply by Sean Nash on 28 October 2022, 14:45 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 28 October 2022, 09:49 https://devapps.diality.us/cru/HD-DEN-13801-1#c14658 Remove commented out line of code. Reply by Michael Garthwaite on 28 October 2022, 13:30 > Fixed. Thanks! Reply by Sean Nash on 28 October 2022, 14:45 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 28 October 2022, 09:49 https://devapps.diality.us/cru/HD-DEN-13801-1#c14659 Remove commented out line of code. Reply by Michael Garthwaite on 28 October 2022, 13:30 > Fixed. Thanks! Reply by Sean Nash on 28 October 2022, 14:44 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 21 October 2022, 13:15 https://devapps.diality.us/cru/HD-DEN-13801-1#c14550 Move blank line from above to below declaration. Reply by Michael Garthwaite on 21 October 2022, 14:16 > Fixed. Thanks! Reply by Sean Nash on 21 October 2022, 14:23 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 28 October 2022, 09:51 https://devapps.diality.us/cru/HD-DEN-13801-1#c14661 Remove extra blank line. Reply by Michael Garthwaite on 28 October 2022, 13:30 > Fixed. Thanks! Reply by Sean Nash on 28 October 2022, 14:44 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 28 October 2022, 09:51 https://devapps.diality.us/cru/HD-DEN-13801-1#c14660 Add blank line after declarations. Reply by Michael Garthwaite on 28 October 2022, 13:30 > Fixed. Thanks! Reply by Sean Nash on 28 October 2022, 14:42 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 21 October 2022, 13:14 https://devapps.diality.us/cru/HD-DEN-13801-1#c14549 Remove blank line. Reply by Michael Garthwaite on 21 October 2022, 14:16 > Fixed. Thanks! Reply by Sean Nash on 21 October 2022, 14:25 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 28 October 2022, 09:52 https://devapps.diality.us/cru/HD-DEN-13801-1#c14662 Remove dead code. Reply by Michael Garthwaite on 28 October 2022, 13:30 > Fixed. Thanks! Reply by Sean Nash on 28 October 2022, 14:43 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 21 October 2022, 13:13 https://devapps.diality.us/cru/HD-DEN-13801-1#c14548 Remove blank line. Reply by Michael Garthwaite on 21 October 2022, 14:16 > Fixed. Thanks! Reply by Sean Nash on 21 October 2022, 14:25 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 28 October 2022, 09:52 https://devapps.diality.us/cru/HD-DEN-13801-1#c14663 Add blank line before return. Reply by Michael Garthwaite on 28 October 2022, 13:30 > Fixed. Thanks! Reply by Sean Nash on 28 October 2022, 14:42 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModePreTreat.h Revision Comment by Sean Nash on 21 October 2022, 11:38 https://devapps.diality.us/cru/HD-DEN-13801-1#c14544 Remove extra blank line. Reply by Michael Garthwaite on 21 October 2022, 14:17 > Fixed. Thanks! Reply by Sean Nash on 21 October 2022, 14:22 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 21 October 2022, 11:38 https://devapps.diality.us/cru/HD-DEN-13801-1#c14543 Remove extra blank line. Reply by Michael Garthwaite on 21 October 2022, 14:17 > Fixed. Thanks! Reply by Sean Nash on 21 October 2022, 14:26 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/Prime.c Revision Comment by Sean Nash on 28 October 2022, 09:33 https://devapps.diality.us/cru/HD-DEN-13801-1#c14646 Remove blank line. Reply by Michael Garthwaite on 28 October 2022, 13:28 > Fixed. Thanks! Reply by Sean Nash on 28 October 2022, 15:07 > RESOLVED in CODE WALKTHROUGH. --- ID: HD-DEN-13801-1 https://devapps.diality.us/cru/HD-DEN-13801-1 Title: HD-DEN-13801_SW Dev Sprint 79 MG Statement of Objectives: State: Closed Summary: Author: Michael Garthwaite Moderator: Michael Garthwaite Reviewers: (1 active, 3 completed*) Sean Nash (*) wbracken (*) Dara Navaei (*) Darren Cox