HD-DEN-13834-1 HD-DEN-13834_DG HD Dev HD DG Dvt Update Part 3

closed on 18 Oct 23

Author

Moderator

Reviewers

HD-DEN-13834_DG HD Dev HD DG Dvt Update Part 3

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 76

common 0
- File AlarmDefs.h 21 Remove
- File DGDefs.h 3 Remove
- File HDDefs.h 5 Remove
- File MsgDefs.h 0 Remove
fwcommon 0
- File Common.h 0 Remove
- File Integrity.c 0 Remove
- File Integrity.h 0 Remove
- File NVDataMgmt.c 16 Remove
- File NVDataMgmt.h 0 Remove
- File NVDataMgmtDGRecords.h 0 Remove
- File NVDataMgmtHDRecords.h 0 Remove
- File PersistentAlarm.c 3 Remove
- File PersistentAlarm.h 0 Remove
- File RTC.c 3 Remove
- File RTC.h 0 Remove
- File Timers.c 0 Remove
- File Utilities.c 9 Remove
- File Utilities.h 0 Remove
hdfirmware 0
- Folder firmware 0
  - Folder .launches 0
    - File HD.launch 0 Remove
    - File SeanTest.launch 0 Remove
    - File VCAST_DEBUG.launch 0 Remove
  - Folder App 0
    - Folder Controllers 0
      - File BloodFlow.c 0 Remove
      - File BloodFlow.h 0 Remove
      - File BloodLeak.c 6 Remove
      - File BloodLeak.h 0 Remove
      - File DGInterface.c 24 Remove
      - File DGInterface.h 2 Remove
      - File DialInFlow.c 0 Remove
      - File DialInFlow.h 0 Remove
      - File DialOutFlow.c 0 Remove
      - File DialOutFlow.h 0 Remove
      - File Fans.c 0 Remove
      - File PresOccl.c 3 Remove
      - File PresOccl.h 0 Remove
      - File SyringePump.c 0 Remove
      - File SyringePump.h 0 Remove
      - File Temperatures.c 3 Remove
      - File Temperatures.h 0 Remove
      - File Valves.c 0 Remove
      - File Voltages.c 0 Remove
    - Folder Drivers 0
      - File Battery.c 0 Remove
      - File Battery.h 0 Remove
      - File InternalADC.c 0 Remove
      - File SafetyShutdown.c 0 Remove
    - Folder Modes 0
      - File BloodPrime.c 3 Remove
      - File Dialysis.c 3 Remove
      - File ModeFault.c 12 Remove
      - File ModeInitPOST.c 0 Remove
      - File ModePreTreat.c 3 Remove
      - File ModeStandby.c 9 Remove
      - File ModeTreatment.c 0 Remove
      - File ModeTreatmentParams.c 0 Remove
      - File OperationModes.c 0 Remove
      - File OperationModes.h 0 Remove
      - File PreTreatmentRecirc.c 0 Remove
      - File Prime.c 5 Remove
      - File Rinseback.c 0 Remove
      - File SelfTests.c 0 Remove
      - File TreatmentStop.c 0 Remove
    - Folder Services 0
      - File AlarmMgmt.c 0 Remove
      - File AlarmMgmt.h 0 Remove
      - File AlarmMgmtSWFaults.h 0 Remove
      - File CommBuffers.c 0 Remove
      - File FPGA.c 6 Remove
      - File FPGA.h 0 Remove
      - File Reservoirs.c 0 Remove
      - File SystemComm.c 0 Remove
      - File SystemCommMessages.c 6 Remove
      - File SystemCommMessages.h 0 Remove
      - File WatchdogMgmt.c 0 Remove
    - Folder Tasks 0
      - File TaskBG.c 0 Remove
      - File TaskGeneral.c 5 Remove
      - File TaskPriority.c 0 Remove
    - File HDCommon.h 3 Remove
  - Folder source 0
    - File sys_main.c 0 Remove
  - File .gitignore 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Dara Navaei	Author & Moderator	2h 50m	53	RESOLVED in CODE WALKTHROUGH
Sean Nash	Reviewer - Complete	3h 13m	56	RESOLVED in CODE WALKTHROUGH.
Michael Garthwaite	Reviewer - 9% reviewed	1h 21m	2	RESOLVED in CODE WALKTHROUGH.
wbracken (deleted user)	Reviewer - Complete	3h 53m	39	RESOLVED IN CODE WALKTHROUGH
Darren Cox	Reviewer - 40% reviewed	51m	3	Put define on left of comparison. DG_MODE_HEAT != dgOp.
Total		12h 10m	153

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

HD-DEN-13834-1

HD-DEN-13834_DG HD Dev HD DG Dvt Update Part 3

HD-DEN-13834-1 153

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

HD-DEN-13834_DG HD Dev HD DG Dvt Update Part 3

HD-DEN-13834-1 153

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time