This is a list of all comments for HD-DEN-13903-2. Review Summary: No summary ---------------------------------------- File: firmware/App/Controllers/AirTrap.c Revision Comment by Sean Nash on 12 October 2022, 08:43 https://devapps.diality.us/cru/HD-DEN-13903-2#c14183 Should have an else here where we reset (zero) airTrapIllegalLevelSensorsCtr. Reply by Michael Garthwaite on 12 October 2022, 08:51 > This is an older style of persistence? line 214 shows that > airTrapIllegalLevelSensorsCtr gets decremented if it is > greater than 0. Reply by Sean Nash on 21 October 2022, 11:27 > I think this check is for over-fill. Counter is for > illegal level sensor readings. Over-fill check should have > it's own counter (or use new persistence style) and we > should reset that separate counter in the "else" condition. Reply by Michael Garthwaite on 21 October 2022, 14:52 > Fixed. Using the old style for now. Will rework both > alarms to use new persistence when we revisit the > dialyzer timeout alarms in priming. Reply by Sean Nash on 21 October 2022, 14:56 > Fine for now. This one should probably just reset to > zero on else instead of decrement. > RESOLVED in CODE WALKTHROUGH. Revision Comment by wbracken on 23 September 2022, 15:00 https://devapps.diality.us/cru/HD-DEN-13903-2#c13954 Need separate config? Reply by Dara Navaei on 19 October 2023, 09:18 > RESOLVED in CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Modes/ModePreTreat.c Revision Comment by Sean Nash on 12 October 2022, 08:45 https://devapps.diality.us/cru/HD-DEN-13903-2#c14184 Add a TODO to restore this to 100 when open DPi flow control fixed. Reply by Michael Garthwaite on 12 October 2022, 15:01 > Fixed. Thanks! Reply by Sean Nash on 12 October 2022, 15:55 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/PreTreatmentRecirc.c Revision Comment by Sean Nash on 12 October 2022, 08:47 https://devapps.diality.us/cru/HD-DEN-13903-2#c14185 Add TODO to restore to 100 when DPi flow control is fixed. Reply by Michael Garthwaite on 12 October 2022, 15:01 > Fixed. Thanks! Reply by Sean Nash on 12 October 2022, 15:55 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/Prime.c Revision Comment by wbracken on 23 September 2022, 15:02 https://devapps.diality.us/cru/HD-DEN-13903-2#c13955 Update function header. primeFirstPurgePass Reply by Michael Garthwaite on 12 October 2022, 15:05 > Fixed. Thanks! Reply by wbracken on 12 October 2022, 15:46 > FIXED IN CODE WALKTHROUGH Reply by Dara Navaei on 19 October 2023, 09:18 > RESOLVED in CODE WALKTHROUGH Revision Comment by wbracken on 18 October 2022, 16:56 https://devapps.diality.us/cru/HD-DEN-13903-2#c14515 Update function header Reply by Michael Garthwaite on 21 October 2022, 14:53 > Fixed. Thanks! Reply by wbracken on 21 October 2022, 15:59 > RESOLVED IN CODE WALKTHROUGH Revision Comment by Sean Nash on 12 October 2022, 08:53 https://devapps.diality.us/cru/HD-DEN-13903-2#c14188 Why are we setting BP speed here? Wouldn't BP already be setup prior to this state? What does fluid at lower level have to do with BP speed? Reply by Michael Garthwaite on 12 October 2022, 14:56 > This is blood flow? Reply by Sean Nash on 21 October 2022, 11:23 > Corrected comment above. Why are we changing BP flow rate > at air trap lower level? Should be set to slow or fast on > entry to this state (depending on whether this is 1st pass > or not) and stay at that rate for duration of this pass. Reply by Michael Garthwaite on 21 October 2022, 14:19 > Fixed. Thanks! Reply by Sean Nash on 21 October 2022, 14:55 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 12 October 2022, 08:54 https://devapps.diality.us/cru/HD-DEN-13903-2#c14192 Wouldn't we set primeFirstPurgePass to FALSE here (we've just completed first pass and we're leaving)? And so shouldn't we just set BP to the faster rate now? Reply by Michael Garthwaite on 12 October 2022, 14:58 > During Saline circ blood circuit state, we are also running > the BP at the same rate as purge air as we monitor the level. > Do we want the first pass of that state to be ramped up? > Also, DPi? Reply by Sean Nash on 21 October 2022, 11:22 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 12 October 2022, 08:56 https://devapps.diality.us/cru/HD-DEN-13903-2#c14193 I think this flag should be set to FALSE in prior state as we transition to this state. Reply by Michael Garthwaite on 12 October 2022, 14:59 > Please see comment above. Reply by Sean Nash on 21 October 2022, 11:21 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 12 October 2022, 08:49 https://devapps.diality.us/cru/HD-DEN-13903-2#c14186 Remove blank line. Reply by Michael Garthwaite on 12 October 2022, 15:02 > Fixed. Thanks! Reply by Sean Nash on 12 October 2022, 15:55 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 12 October 2022, 08:57 https://devapps.diality.us/cru/HD-DEN-13903-2#c14194 This seems very similar to condition above. Is this a merge issue? Do we need both? Reply by Sean Nash on 21 October 2022, 14:38 > Seems like largest calculated t/o = 38.2 seconds vs. 60 > second alarm t/o. > Let's leave as is for now, but add a TODO comment here to > remove alarm t/o and associated alarm. Reply by Michael Garthwaite on 21 October 2022, 14:47 > Fixed. Thanks! Reply by Sean Nash on 21 October 2022, 14:55 > RESOLVED in CODE WALKTHROUGH. --- ID: HD-DEN-13903-2 https://devapps.diality.us/cru/HD-DEN-13903-2 Title: HD-DEN-13903_Sprint 80 MG Air Trap Optimization Statement of Objectives: State: Closed Summary: Author: Michael Garthwaite Moderator: Michael Garthwaite Reviewers: (2 active, 2 completed*) Sean Nash (*) wbracken (*) Dara Navaei Darren Cox