This is a list of all comments for HD-DEN-14007-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/ModePostTreat.c
Revision Comment by Sean Nash on 15 December 2022, 22:28 
https://devapps.diality.us/cru/HD-DEN-14007-1#c15246

  Add "in ms" to comment.

  Reply by Darren Cox on 19 December 2022, 15:40
  > Updated.

    Reply by Sean Nash on 20 December 2022, 09:06
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 15 December 2022, 22:40 
https://devapps.diality.us/cru/HD-DEN-14007-1#c15249

  functions/vars should be named a little more descriptively.
  Instead of drain DG, something like de-prime DG dialysate line.

  Reply by Darren Cox on 19 December 2022, 15:40
  > Function and State names updated.

    Reply by Sean Nash on 20 December 2022, 09:08
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 20 December 2022, 09:09 
https://devapps.diality.us/cru/HD-DEN-14007-1#c15411

  These should be moved to init function (which is called by this
  function).

  Reply by Darren Cox on 20 December 2022, 11:47
  > Moved to Init.

    Reply by Sean Nash on 20 December 2022, 14:15
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 15 December 2022, 22:34 
https://devapps.diality.us/cru/HD-DEN-14007-1#c15247

  Prefer these two statics be moved up to file level scope so
  these can be initialized on every transition into post
  treatment mode.

  Reply by Darren Cox on 19 December 2022, 15:41
  > Moved to module, initialized in mode init function.

    Reply by Sean Nash on 20 December 2022, 09:10
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 15 December 2022, 22:38 
https://devapps.diality.us/cru/HD-DEN-14007-1#c15248

  Use the hard stop function to stop the pump.

  Reply by Darren Cox on 19 December 2022, 15:42
  > Updated to hard stop function.

    Reply by Sean Nash on 20 December 2022, 09:11
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/BloodFlow.c
Revision Comment by Sean Nash on 15 December 2022, 22:21 
https://devapps.diality.us/cru/HD-DEN-14007-1#c15241

  Use float literals (e.g. 1 s/b 1.0F).

  Reply by Darren Cox on 19 December 2022, 15:39
  > Updated.

    Reply by Sean Nash on 20 December 2022, 09:04
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Controllers/DialInFlow.c
Revision Comment by Sean Nash on 15 December 2022, 22:26 
https://devapps.diality.us/cru/HD-DEN-14007-1#c15244

  Use float literals.

  Reply by Darren Cox on 19 December 2022, 15:39
  > Updated.

    Reply by Sean Nash on 20 December 2022, 09:05
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by wbracken on 13 December 2022, 17:41 
https://devapps.diality.us/cru/HD-DEN-14007-1#c15196

  Update function header.

  Reply by Darren Cox on 19 December 2022, 15:39
  > Updated.

    Reply by wbracken on 19 December 2022, 15:56
    > UPDATED IN CODE WALKTHROUGH.

      Reply by Dara Navaei on 19 October 2023, 09:10
      > RESOLVED in CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Controllers/DialOutFlow.c
Revision Comment by Sean Nash on 15 December 2022, 22:27 
https://devapps.diality.us/cru/HD-DEN-14007-1#c15245

  Use float literals.

  Reply by Darren Cox on 19 December 2022, 15:39
  > Updated.

    Reply by Sean Nash on 20 December 2022, 09:06
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by wbracken on 13 December 2022, 17:42 
https://devapps.diality.us/cru/HD-DEN-14007-1#c15197

  Update function header.

  Reply by Darren Cox on 19 December 2022, 15:39
  > Updated.

    Reply by wbracken on 19 December 2022, 15:56
    > RESOLVED IN CODE WALKTHROUGH.


---

ID: HD-DEN-14007-1 https://devapps.diality.us/cru/HD-DEN-14007-1

Title: HD-DEN-14007_Change Request DE Prime Dialysate Lines
Statement of Objectives:


State: Closed

Summary: 

Author: Darren Cox
Moderator: Darren Cox
Reviewers: (3 active, 2 completed*)
     Sean Nash   (*)
     Dara Navaei   (*)
     wbracken
     Michael Garthwaite
     jtaylor