This is a list of all comments for HD-DEN-14011-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/PresOccl.c
Revision Comment by Sean Nash on 20 January 2023, 09:06 
https://devapps.diality.us/cru/HD-DEN-14011-1#c16172

  Not sure exception for treatment stop state still makes sense.
  We can be running BP in that state now depending on alarm.
  Should still alarm on occlusion.

  Reply by Michael Garthwaite on 20 January 2023, 11:27
  > Fixed. Only checking if BP is running when are in treatment
  > mode.

    Reply by Sean Nash on 20 January 2023, 11:38
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/SelfTests.c
Revision Comment by Sean Nash on 20 January 2023, 13:59 
https://devapps.diality.us/cru/HD-DEN-14011-1#c16189

  Should set pump track closed required, but not door here.

  Reply by Michael Garthwaite on 20 January 2023, 15:54
  > Fixed. Thanks!

    Reply by Sean Nash on 20 January 2023, 16:01
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 20 January 2023, 09:11 
https://devapps.diality.us/cru/HD-DEN-14011-1#c16173

  Should this 10 seconds only start once latch is locked?

  Reply by Michael Garthwaite on 20 January 2023, 11:28
  > Fixed. Created handleDrySelfTestStartState() that counts
  > settle time once the latch is determined closed.

    Reply by Sean Nash on 20 January 2023, 11:35
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 20 January 2023, 14:00 
https://devapps.diality.us/cru/HD-DEN-14011-1#c16191

  transition and resume part of stopped state should set pump
  track required so we don't have to keep setting it here every
  50 ms.

  Reply by Michael Garthwaite on 20 January 2023, 15:54
  > Fixed. Thanks!

    Reply by Sean Nash on 20 January 2023, 16:00
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 20 January 2023, 14:00 
https://devapps.diality.us/cru/HD-DEN-14011-1#c16190

  Should set door and pump track required here before we move on
  to next state.

  Reply by Michael Garthwaite on 20 January 2023, 15:54
  > Fixed. Thanks!

    Reply by Sean Nash on 20 January 2023, 16:01
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 20 January 2023, 11:36 
https://devapps.diality.us/cru/HD-DEN-14011-1#c16182

  Do we need an else where we reset 10 second start time (if
  latch opened)?

  Reply by Sean Nash on 20 January 2023, 14:02
  > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 20 January 2023, 09:13 
https://devapps.diality.us/cru/HD-DEN-14011-1#c16174

  Should this be moved into "if" body?  Doesn't appear to need
  setting until we resume.

  Reply by Michael Garthwaite on 20 January 2023, 11:28
  > Fixed. Thanks!

    Reply by Sean Nash on 20 January 2023, 11:34
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 20 January 2023, 14:05 
https://devapps.diality.us/cru/HD-DEN-14011-1#c16193

  If going back to start state, set pump track closed required,
  but not door closed.  If skipping dry self-tests, set both to
  be required closed.
  
  Also, this s/w config looks like it's setup wrong.  For release
  build, we want to go back to start state.

  Reply by Michael Garthwaite on 20 January 2023, 15:54
  > Fixed. Thanks!

    Reply by Sean Nash on 20 January 2023, 15:59
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-14011-1 https://devapps.diality.us/cru/HD-DEN-14011-1

Title: HD-DEN-14011_Occulsion Alarm When Reseating
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (4 active, 2 completed*)
     Sean Nash   (*)
     wbracken   (*)
     Dara Navaei
     Darren Cox
     jtaylor
     Steve Jarpe