This is a list of all comments for HD-DEN-14099-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/Prime.c
Revision Comment by Michael Garthwaite on 22 November 2022, 15:52 
https://devapps.diality.us/cru/HD-DEN-14099-1#c15052

  please fix naming. comment says arterial but define is calling
  it as venous.

  Reply by Darren Cox on 28 November 2022, 12:30
  > Updated to venous.  Good catch.

    Reply by Michael Garthwaite on 29 November 2022, 08:43
    > RESOLVED IN CODE WALKTHROUGH.

Revision Comment by Sean Nash on 18 November 2022, 15:12 
https://devapps.diality.us/cru/HD-DEN-14099-1#c14864

  Magic # 5 - use #define.
  What happens if prior bubble clear is still active when this
  times out?  Seems like condition should check that
  bubbleClearActive is FALSE too.

  Reply by Darren Cox on 28 November 2022, 12:30
  > Added define.  There is no harm in closing valve if already
  > closed.  TODO comment below is a place holder for checking if
  > closed too long.  More testing by systems needed to determine
  > if this is necessary.

    Reply by Sean Nash on 19 December 2022, 09:29
    > Code is removed.  RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 18 November 2022, 15:15 
https://devapps.diality.us/cru/HD-DEN-14099-1#c14865

  If this condition (timeout) occurs in middle of pressure build
  up, will we release on transition to next state?

  Reply by Darren Cox on 28 November 2022, 12:33
  > Updated to reset valve position and flag.

    Reply by Sean Nash on 19 December 2022, 09:30
    > This state should no longer be pressurizing (moved to blood
    > prime state).  Remove opening of VDi valve - no longer
    > needed or appropriate.

      Reply by Darren Cox on 19 December 2022, 14:48
      > Cleaned up missed artifacts from moving the bubble
      > pressure code.

        Reply by Sean Nash on 20 December 2022, 09:03
        > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-14099-1 https://devapps.diality.us/cru/HD-DEN-14099-1

Title: HD-DEN-14099_Bubbles IN Dialysate Out Line From DG TO Cartridge
Statement of Objectives:


State: Closed

Summary: 

Author: Darren Cox
Moderator: Darren Cox
Reviewers: (3 active, 2 completed*)
     Sean Nash   (*)
     Dara Navaei   (*)
     Michael Garthwaite
     wbracken
     jtaylor