This is a list of all comments for HD-DEN-14150-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Controllers/DialInFlow.c Revision Comment by Sean Nash on 07 November 2022, 10:25 https://devapps.diality.us/cru/HD-DEN-14150-1#c14798 Remove test code. Reply by Dong Nguyen on 07 November 2022, 10:48 > Removed. Reply by Sean Nash on 07 November 2022, 10:56 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Dong Nguyen on 18 October 2022, 10:09 https://devapps.diality.us/cru/HD-DEN-14150-1#c14470 Removed the commented-out line. Reply by Dara Navaei on 19 October 2023, 10:06 > RESOLVED in CODE WALKTHROUGH Revision Comment by Michael Garthwaite on 26 October 2022, 13:17 https://devapps.diality.us/cru/HD-DEN-14150-1#c14641 Please update the DIP_ML_PER_MIN_FROM_PWM to reflect the changes in DIP_PWM_FROM_ML_PER_MIN. DIP_ML_PER_MIN_FROM_PWM should be the inverse equation of DIP_PWM_FROM_ML_PER_MIN. The rate in ml/min as an output with pwm as its input. Reply by Dong Nguyen on 07 November 2022, 08:53 > Done. Reply by Michael Garthwaite on 07 November 2022, 10:28 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 07 November 2022, 10:25 https://devapps.diality.us/cru/HD-DEN-14150-1#c14800 Remove test code. Reply by Dong Nguyen on 07 November 2022, 10:39 > I already removed the test code (at line 116). > I just checked and it was removed in my local version. I > already pushed DEN-14150. > Please pull it gain to see if the test code is still there. > Thank you. Reply by Sean Nash on 07 November 2022, 10:55 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Dong Nguyen on 18 October 2022, 10:08 https://devapps.diality.us/cru/HD-DEN-14150-1#c14469 Removed the commented-out line. Reply by Dara Navaei on 11 November 2022, 13:41 > RESOLVED in CODE WALKTHROUGH Revision Comment by wbracken on 17 October 2022, 15:07 https://devapps.diality.us/cru/HD-DEN-14150-1#c14455 Update function header. dialysateInPumpRotorCounter.data, dipStopAtHomePosition also output. Reply by Dong Nguyen on 18 October 2022, 09:52 > Updated the function header to include > dialysateInPumpRotorCounter. and dipStopAtHomePosition as > output. Reply by wbracken on 18 October 2022, 10:59 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 18 October 2022, 11:00 https://devapps.diality.us/cru/HD-DEN-14150-1#c14473 Align second line with opening parenthesis of line above. Reply by Dong Nguyen on 18 October 2022, 11:37 > Done. Reply by wbracken on 19 October 2022, 11:06 > RESOLVED IN CODE WALKTHROUGH Revision Comment by Sean Nash on 27 October 2022, 13:06 https://devapps.diality.us/cru/HD-DEN-14150-1#c14642 Make #define for 0.5. Reply by Dong Nguyen on 04 November 2022, 13:21 > Done. Reply by Sean Nash on 04 November 2022, 15:24 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 27 October 2022, 13:08 https://devapps.diality.us/cru/HD-DEN-14150-1#c14643 Should use get function instead of filtered.... We would want override to affect this check. Probably means we have to move this check to function that calls this function after override structure is set to new estimate. Reply by Dong Nguyen on 04 November 2022, 13:14 > Yes, now call isDialInPumpRunning(). Done. Reply by Sean Nash on 04 November 2022, 15:26 > Not what I meant. I mean when we're determining whether > the measured flow is within 50% of estimated flow, we > should use the get function (that allows override to be > considered) instead of using > filteredDialinFlowMeterReading. Reply by Dong Nguyen on 07 November 2022, 11:04 > Done. Now use the function getMeasuredDialInFlowRate() > instead of using filteredDialinFlowMeterReading. Reply by Dong Nguyen on 07 November 2022, 13:54 > Done. > I move the alarm ALARM_ID_HD_DIAL_IN_FLOW_CHECK_FAILURE > check to the function checkDialInPumpFlowRate(), which > calls function getMeasuredDialInFlowRate() and function > getDGDialysateFlowRateLMin() instead of using > filteredDialinFlowMeterReading. Reply by Sean Nash on 08 November 2022, 09:05 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 08 November 2022, 09:02 https://devapps.diality.us/cru/HD-DEN-14150-1#c14823 Remove extra blank line. Should only be 1 blank line between functions. Reply by Dong Nguyen on 08 November 2022, 09:28 > Removed. Done. Reply by Sean Nash on 08 November 2022, 09:32 > RESOLVED in CODE WALKTHROUGH. Revision Comment by wbracken on 18 October 2022, 11:07 https://devapps.diality.us/cru/HD-DEN-14150-1#c14475 SW_CONFIG_ENABLE_VALUE should be first item in conditional when checking against == Reply by Dong Nguyen on 18 October 2022, 11:34 > Done. Updated with SW_CONFIG_ENABLE_VALUE is the first item. Reply by wbracken on 18 October 2022, 15:17 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 18 October 2022, 11:08 https://devapps.diality.us/cru/HD-DEN-14150-1#c14476 Instead of 0 maybe a constant Reply by Dong Nguyen on 04 November 2022, 14:30 > dialysateInPumpRotorCounter.data = 0.0F; Done. Reply by wbracken on 04 November 2022, 14:54 > RESOLVED IN CODE WALKTHROUGH. Revision Comment by wbracken on 17 October 2022, 15:14 https://devapps.diality.us/cru/HD-DEN-14150-1#c14457 If not used should be removed. Reply by Dong Nguyen on 18 October 2022, 09:46 > Removed the commented-out line. Reply by wbracken on 18 October 2022, 11:13 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Controllers/DGInterface.c Revision Comment by Sean Nash on 19 October 2022, 08:43 https://devapps.diality.us/cru/HD-DEN-14150-1#c14524 Uncomment this line. Reply by Sean Nash on 19 October 2022, 09:11 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/Switches.c Revision Comment by Sean Nash on 19 October 2022, 08:44 https://devapps.diality.us/cru/HD-DEN-14150-1#c14525 Uncomment line. Reply by Sean Nash on 19 October 2022, 09:10 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeStandby.c Revision Comment by Sean Nash on 19 October 2022, 08:44 https://devapps.diality.us/cru/HD-DEN-14150-1#c14526 Uncomment line. Reply by Sean Nash on 19 October 2022, 09:10 > RESOLVED in CODE WALKTHROUGH. Revision Comment by wbracken on 21 October 2022, 13:44 https://devapps.diality.us/cru/HD-DEN-14150-1#c14551 SW_CONFIG_ENABLE_VALUE should be first blue in if statement Reply by Dong Nguyen on 04 November 2022, 15:47 > Done. Reply by wbracken on 04 November 2022, 16:46 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/source/sys_main.c Revision Comment by wbracken on 18 October 2022, 15:19 https://devapps.diality.us/cru/HD-DEN-14150-1#c14507 What are all the blank lines? Reply by Dong Nguyen on 18 October 2022, 17:25 > Removed all blank lines. Reply by wbracken on 19 October 2022, 11:05 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Modes/ModeTreatment.c Revision Comment by Sean Nash on 11 November 2022, 13:57 https://devapps.diality.us/cru/HD-DEN-14150-1#c14859 Need to make sure these only get called once before pre-treatment. Reply by Dara Navaei on 11 November 2022, 14:19 > Done Reply by Sean Nash on 11 November 2022, 15:17 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Drivers/Battery.c Revision Comment by Sean Nash on 03 November 2022, 09:04 https://devapps.diality.us/cru/HD-DEN-14150-1#c14707 Add a space between "return" and "(". Reply by Dong Nguyen on 04 November 2022, 13:11 > Done. Reply by Sean Nash on 04 November 2022, 15:22 > RESOLVED in CODE WALKTHROUGH. --- ID: HD-DEN-14150-1 https://devapps.diality.us/cru/HD-DEN-14150-1 Title: HD-DEN-14150_HD Dialysate Flow Estimation Statement of Objectives: State: Closed Summary: Author: Steve Jarpe Moderator: Steve Jarpe Reviewers: (4 active, 2 completed*) Sean Nash (*) Dara Navaei (*) wbracken Michael Garthwaite Darren Cox Dong Nguyen