This is a list of all comments for HD-DEN-14175-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/BloodLeak.c
Revision Comment by wbracken on 27 October 2022, 13:34 
https://devapps.diality.us/cru/HD-DEN-14175-1#c14644

  Remove TODO comment.

  Reply by Dara Navaei on 03 November 2022, 09:51
  > This function should stay commented. I have a TODO task for
  > this.

    Reply by wbracken on 03 November 2022, 10:23
    > RESOLVED IN CODE WALKTHROUGH

Revision Comment by wbracken on 27 October 2022, 13:35 
https://devapps.diality.us/cru/HD-DEN-14175-1#c14645

  Remove

  Reply by Dara Navaei on 03 November 2022, 09:52
  > Done.

    Reply by wbracken on 03 November 2022, 10:23
    > RESOLVED IN CODE WALKTHROUGH

----------------------------------------
File: Compatible.h
Revision Comment by Sean Nash on 28 October 2022, 15:09 
https://devapps.diality.us/cru/HD-DEN-14175-1#c14702

  This revision also applies to UI.

  Reply by Dara Navaei on 03 November 2022, 09:50
  > Done.

    Reply by Sean Nash on 07 November 2022, 10:39
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: RTC.c
Revision Comment by Sean Nash on 28 October 2022, 15:12 
https://devapps.diality.us/cru/HD-DEN-14175-1#c14703

  hasReg1Failed is initialized to FALSE.  Should we be setting to
  TRUE in these ifs?  Or should the initialize be setting to
  TRUE?

  Reply by Dara Navaei on 03 November 2022, 09:49
  > No these should be TRUE.

    Reply by Sean Nash on 07 November 2022, 10:43
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: MsgDefs.h
Revision Comment by Sean Nash on 07 November 2022, 10:40 
https://devapps.diality.us/cru/HD-DEN-14175-1#c14807

  If this message is for DG CPLD only, should change enum to
  "MSG_ID_DG_CPLD_...".

  Reply by Dara Navaei on 09 November 2022, 13:13
  > Done

    Reply by Sean Nash on 09 November 2022, 13:59
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: Utilities.h
Revision Comment by Sean Nash on 07 November 2022, 10:44 
https://devapps.diality.us/cru/HD-DEN-14175-1#c14812

  Why is this in utilities module?  Doesn't it make more sense in
  fpga module?

  Reply by Dara Navaei on 07 November 2022, 11:27
  > This is here so both stacks can use it.

    Reply by Sean Nash on 09 November 2022, 08:43
    > Still doesn't belong here.  We can either have a new shared
    > FPGA header file or we can have two of these - one for each
    > sub-system (similar to how we have two FPGA.c/.h files).

      Reply by Dara Navaei on 09 November 2022, 13:23
      > Done.

        Reply by Sean Nash on 09 November 2022, 13:54
        > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: Common.h
Revision Comment by Sean Nash on 07 November 2022, 10:41 
https://devapps.diality.us/cru/HD-DEN-14175-1#c14809

  None of these structures appear to require packing - all 32-bit
  fields.

  Reply by Dara Navaei on 09 November 2022, 13:12
  > Done.

    Reply by Sean Nash on 09 November 2022, 13:56
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModePreTreat.c
Revision Comment by wbracken on 03 November 2022, 10:17 
https://devapps.diality.us/cru/HD-DEN-14175-1#c14715

  Remove blank line

  Reply by Dara Navaei on 07 November 2022, 09:33
  > Done.

  Reply by wbracken on 07 November 2022, 10:21
  > Looks like blank line is still there.

    Reply by wbracken on 07 November 2022, 10:36
    > RESOLVED IN CODE WALKTHROUGH

Revision Comment by Sean Nash on 09 November 2022, 08:41 
https://devapps.diality.us/cru/HD-DEN-14175-1#c14833

  Doesn't this command take a pointer to a structure now?

  Reply by Dara Navaei on 09 November 2022, 13:11
  > Done.

    Reply by Sean Nash on 09 November 2022, 13:54
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/TreatmentEnd.c
Revision Comment by wbracken on 03 November 2022, 10:20 
https://devapps.diality.us/cru/HD-DEN-14175-1#c14716

  Update function header.

  Reply by Dara Navaei on 07 November 2022, 09:37
  > Done.

    Reply by wbracken on 07 November 2022, 10:40
    > RESOLVED IN CODE WALKTHROUGH

----------------------------------------
File: NVDataMgmt.c
Revision Comment by Sean Nash on 07 November 2022, 10:42 
https://devapps.diality.us/cru/HD-DEN-14175-1#c14810

  Remove blank line.

  Reply by Dara Navaei on 07 November 2022, 11:27
  > Done.

    Reply by Sean Nash on 09 November 2022, 13:55
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-14175-1 https://devapps.diality.us/cru/HD-DEN-14175-1

Title: HD-DEN-14175_DG HD Dev HD DG Dvt Update Part 5
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (2 active, 2 completed*)
     Sean Nash   (*)
     wbracken   (*)
     Michael Garthwaite
     Darren Cox