This is a list of all comments for HD-DEN-14252-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/Prime.c
Revision Comment by jtaylor on 02 December 2022, 09:12 
https://devapps.diality.us/cru/HD-DEN-14252-1#c15094

  It seems strange to add a magic number here, from a defined
  constant. 
  I'd assume (guess) the relation between 300->225 is maintaining
  a delta P along the flow path (or across the membrane?), but it
  might be worth spelling out, at the top with the defines, or as
  a macro function of the input flow rate.

  Reply by Sean Nash on 02 December 2022, 16:37
  > Created a #define for magic number.  
  > Because running pumps in open loop mode (because we're
  > priming and not necessarily any fluid in line to measure flow
  > with) and pumps have different methods of determining PWM
  > duty cycle from a given flow rate, DPo pumps target flow rate
  > needed to be set lower to match the duty cycle with DPi pump.

    Reply by jtaylor on 05 December 2022, 13:42
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-14252-1 https://devapps.diality.us/cru/HD-DEN-14252-1

Title: HD-DEN-14252_System Self Test Failure Occurs Intermittently
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (2 active, 2 completed*)
     Sean Nash   (*)
     jtaylor   (*)
     wbracken
     Michael Garthwaite