This is a list of all comments for HD-DEN-14307-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Services/SystemCommMessages.c
Revision Comment by wbracken on 19 December 2022, 13:53 
https://devapps.diality.us/cru/HD-DEN-14307-1#c15262

  Update function header.

  Reply by Dara Navaei on 21 December 2022, 09:21
  > Done

    Reply by wbracken on 21 December 2022, 12:01
    > RESOLVED IN CODEWALKTHROUGH.

Revision Comment by wbracken on 19 December 2022, 14:02 
https://devapps.diality.us/cru/HD-DEN-14307-1#c15264

  Looks like setServiceTime always returns FALSE.

  Reply by Sean Nash on 20 December 2022, 15:21
  > Agree, though this comment belongs in NVDataMgmt.c where
  > setServiceTime() is lives.  That function should return TRUE
  > if successful.

    Reply by Dara Navaei on 21 December 2022, 09:19
    > Fixed the setServiceTime function. Thanks.

      Reply by wbracken on 21 December 2022, 12:02
      > RESOLVED IN CODEWALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/OperationModes.c
Revision Comment by Sean Nash on 20 December 2022, 15:14 
https://devapps.diality.us/cru/HD-DEN-14307-1#c15509

  All of these terms are integers and cast is coming too late
  (after division).  To prevent loss of precision on division, we
  want to cast both sides of the division as floats.

  Reply by Dara Navaei on 21 December 2022, 09:17
  > Done.

    Reply by Sean Nash on 21 December 2022, 10:02
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/AlarmMgmt.c
Revision Comment by wbracken on 19 December 2022, 13:48 
https://devapps.diality.us/cru/HD-DEN-14307-1#c15257

  Update function header.

  Reply by Dara Navaei on 21 December 2022, 09:30
  > Done

  Reply by wbracken on 21 December 2022, 11:55
  > RESOLVED IN CODEWALKTHROUGH.

Revision Comment by wbracken on 19 December 2022, 13:49 
https://devapps.diality.us/cru/HD-DEN-14307-1#c15258

  Update function header.

  Reply by Dara Navaei on 21 December 2022, 09:29
  > Done

    Reply by wbracken on 21 December 2022, 11:55
    > RESOLVED IN CODEWALKTHROUGH.

Revision Comment by wbracken on 19 December 2022, 13:49 
https://devapps.diality.us/cru/HD-DEN-14307-1#c15259

  Remove comment?

  Reply by Dara Navaei on 21 December 2022, 09:28
  > I think we still want to keep the comment. It has not been
  > implemented yet.

    Reply by wbracken on 21 December 2022, 11:55
    > RESOLVED IN CODEWALKTHROUGH.

Revision Comment by wbracken on 19 December 2022, 13:50 
https://devapps.diality.us/cru/HD-DEN-14307-1#c15260

  Update function header.

  Reply by Dara Navaei on 21 December 2022, 09:27
  > Done

    Reply by wbracken on 21 December 2022, 11:57
    > Should alarmButtonBlockers and ALARM_TABLE also be added.

      Reply by Dara Navaei on 21 December 2022, 13:12
      > Done

        Reply by wbracken on 21 December 2022, 13:56
        > RESOLVED IN CODE WALKTHROUGH.

Revision Comment by wbracken on 19 December 2022, 13:50 
https://devapps.diality.us/cru/HD-DEN-14307-1#c15261

  Update function header.

  Reply by Dara Navaei on 21 December 2022, 09:24
  > Done

    Reply by wbracken on 21 December 2022, 11:59
    > data and alarmButtonBlockers?

      Reply by Dara Navaei on 21 December 2022, 13:07
      > Data is a local variable but added alarmButtonBlockers

        Reply by wbracken on 21 December 2022, 13:43
        > RESOLVED IN CODEWALKTHROUGH.


---

ID: HD-DEN-14307-1 https://devapps.diality.us/cru/HD-DEN-14307-1

Title: HD-DEN-14307_DG HD Dev HD DG Dvt Update Part 6
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (3 active, 2 completed*)
     Sean Nash   (*)
     wbracken   (*)
     Michael Garthwaite
     Darren Cox
     jtaylor