This is a list of all comments for HD-DEN-14457-2.

Review Summary: No summary

General Comment by jtaylor on 21 February 2023, 15:37 
https://devapps.diality.us/cru/HD-DEN-14457-2#c16506

  SyringePump.c was included in this code review in error.  The
  repositories associate the correct files with each branch.


----------------------------------------
File: firmware/App/Controllers/SyringePump.c
Revision Comment by Sean Nash on 27 February 2023, 10:59 
https://devapps.diality.us/cru/HD-DEN-14457-2#c16528

  Saw same change in another branch.  Not clear to me why we
  need/want to change empty state to completed state.

  Reply by jtaylor on 28 February 2023, 08:46
  > So far as I can tell, this file was included in the code
  > review *only*. The repository doesn't include these changes,
  > on this branch.

    Reply by Sean Nash on 28 February 2023, 11:37
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/ModePreTreat.c
Revision Comment by Sean Nash on 27 February 2023, 11:03 
https://devapps.diality.us/cru/HD-DEN-14457-2#c16529

  Why move this?

  Reply by jtaylor on 28 February 2023, 09:05
  > 1. Style, and preference to keep loop control at the top, not
  > buried in the state function.
  > 2. Keep stack size for the state function more predictable.
  > 3. I was considering unwrapping the state machine, starting
  > with a separate pause state, that held for priming to advance
  > to the proper state
  > 
  > Ultimately the simplest change may be limited to just this
  > ifndef. No practical reason to move the declaration in that
  > case.

    Reply by Sean Nash on 28 February 2023, 11:36
    > I don't think it's necessary - but I'm ok with either
    > location for declaration.
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Modes/SelfTests.c
Revision Comment by Sean Nash on 06 March 2023, 09:52 
https://devapps.diality.us/cru/HD-DEN-14457-2#c16584

  Add blank line before return.

  Reply by jtaylor on 06 March 2023, 10:12
  > Done.

    Reply by Sean Nash on 06 March 2023, 16:42
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-14457-2 https://devapps.diality.us/cru/HD-DEN-14457-2

Title: HD-DEN-14457_Reservoir Drains Before Treatment With Pre Treatment Build Flags Off
Statement of Objectives:


State: Closed

Summary: 

Author: jtaylor
Moderator: jtaylor
Reviewers: (5 active, 1 completed*)
     Dara Navaei   (*)
     Sean Nash
     Michael Garthwaite
     wbracken
     Darren Cox
     Steve Jarpe