This is a list of all comments for HD-DEN-14497-12.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/BloodLeak.c
Revision Comment by Sean Nash on 05 January 2023, 13:14 
https://devapps.diality.us/cru/HD-DEN-14497-12#c15846

  Timer variable is actually a time stamp of last command being
  queued - variable name could be clearer.

  Reply by Dara Navaei on 11 January 2023, 08:41
  > Done

    Reply by Sean Nash on 11 January 2023, 09:12
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/SystemCommMessages.c
Revision Comment by Sean Nash on 05 January 2023, 13:07 
https://devapps.diality.us/cru/HD-DEN-14497-12#c15845

  FALSE was correct (throughout) for last param of
  sendAckResponseMsg() if message/request found to be invalid in
  some way, TRUE if message is ok.

  Reply by Dara Navaei on 10 January 2023, 16:46
  > Done

    Reply by Sean Nash on 10 January 2023, 16:51
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 11 January 2023, 09:14 
https://devapps.diality.us/cru/HD-DEN-14497-12#c15897

  Why are these changed back to ACK_NOT_REQUIRED?

  Reply by Dara Navaei on 11 January 2023, 09:18
  > Done

    Reply by Sean Nash on 11 January 2023, 10:55
    > There are many of these - not just this one.

      Reply by Dara Navaei on 11 January 2023, 13:21
      > Done

        Reply by Sean Nash on 11 January 2023, 13:24
        > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-14497-12 https://devapps.diality.us/cru/HD-DEN-14497-12

Title: HD-DEN-14497_DG HD Dev HD DG Dvt Update Part 7
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (5 active, 1 completed*)
     Sean Nash   (*)
     Michael Garthwaite
     wbracken
     Darren Cox
     jtaylor
     Steve Jarpe