This is a list of all comments for HD-DEN-14549-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Modes/Dialysis.c Revision Comment by wbracken on 25 January 2023, 16:38 https://devapps.diality.us/cru/HD-DEN-14549-1#c16224 Alignment Reply by Sean Nash on 27 January 2023, 11:43 > Not required. Reply by wbracken on 31 January 2023, 10:58 > RESOLVED IN CODE WALKTHROUGH Revision Comment by Darren Cox on 26 January 2023, 14:07 https://devapps.diality.us/cru/HD-DEN-14549-1#c16229 Add spaces around < ? Reply by Sean Nash on 27 January 2023, 11:41 > Done. Reply by Darren Cox on 31 January 2023, 11:36 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 25 January 2023, 16:40 https://devapps.diality.us/cru/HD-DEN-14549-1#c16225 Add salineBolusStartRequested to header Reply by Sean Nash on 27 January 2023, 11:43 > Done. Reply by wbracken on 31 January 2023, 10:57 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: AlarmDefs.h Revision Comment by wbracken on 22 January 2023, 21:09 https://devapps.diality.us/cru/HD-DEN-14549-1#c16213 Need to verify SRS and AlarmsDef.h are in sync. Reply by wbracken on 23 January 2023, 10:12 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 25 January 2023, 16:30 https://devapps.diality.us/cru/HD-DEN-14549-1#c16223 Need to verify all alarms with SRS. Reply by Sean Nash on 27 January 2023, 11:44 > Will have you do that when I can merge this branch. Reply by wbracken on 31 January 2023, 11:07 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Controllers/DGInterface.c Revision Comment by wbracken on 12 January 2023, 17:09 https://devapps.diality.us/cru/HD-DEN-14549-1#c15974 Add dgServiceAndUsageData to header. Reply by Sean Nash on 13 January 2023, 08:46 > It is in the header under Outputs. Reply by wbracken on 17 January 2023, 09:44 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Modes/ModePreTreat.c Revision Comment by wbracken on 31 January 2023, 11:01 https://devapps.diality.us/cru/HD-DEN-14549-1#c16255 Add alarmActionResumeReceived. Reply by Sean Nash on 31 January 2023, 11:20 > Fixed. Reply by wbracken on 31 January 2023, 18:05 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Modes/SelfTests.c Revision Comment by wbracken on 17 January 2023, 09:53 https://devapps.diality.us/cru/HD-DEN-14549-1#c16041 Add pressureSelfTestPreNormalStartTime to header. Reply by Sean Nash on 17 January 2023, 11:35 > Done. Reply by wbracken on 17 January 2023, 14:56 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 17 January 2023, 09:55 https://devapps.diality.us/cru/HD-DEN-14549-1#c16043 Add pressureSelfTestPreNormalStartTime to header. Reply by Sean Nash on 17 January 2023, 11:32 > Done. Reply by wbracken on 17 January 2023, 14:57 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 17 January 2023, 09:57 https://devapps.diality.us/cru/HD-DEN-14549-1#c16044 Add pressureSelfTestNormalizedStartTime to header. Reply by Sean Nash on 17 January 2023, 11:32 > Done. Reply by wbracken on 17 January 2023, 14:58 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Modes/TreatmentStop.c Revision Comment by Darren Cox on 17 January 2023, 12:11 https://devapps.diality.us/cru/HD-DEN-14549-1#c16057 Inconsistent naming here. StopSyringePump, StartHeparinPump. Suggest using same name for both. Reply by Sean Nash on 17 January 2023, 13:03 > They're kind of different. The stop function is fairly > straightforward and is part of syringe pump driver. The > start function is a lot more complex as it needs to figure > out what it should be doing and is part of treatment mode > module. Reply by Darren Cox on 18 January 2023, 11:15 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Modes/Prime.c Revision Comment by jtaylor on 20 January 2023, 15:28 https://devapps.diality.us/cru/HD-DEN-14549-1#c16195 Extra white space. Reply by Sean Nash on 27 January 2023, 13:37 > Fixed. Reply by jtaylor on 30 January 2023, 08:27 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Controllers/BloodFlow.c Revision Comment by Darren Cox on 18 January 2023, 11:09 https://devapps.diality.us/cru/HD-DEN-14549-1#c16093 This check for _IN_TREATMENT may need to be added to Valves.c ALARM_ID_HD_AC_POWER_LOST check from recent bug fix. Both look to be checked in every case. Is this flag used independently anywhere? Reply by Sean Nash on 18 January 2023, 11:50 > I don't think I have this bug fix in my branch. Needs to be > addressed in a more recent branch. Reply by Darren Cox on 18 January 2023, 11:55 > Yes, may need to be done when merging to Staging. Is this > flag used independently anywhere? Or planned to be? Reply by Darren Cox on 18 January 2023, 12:38 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Drivers/Battery.c Revision Comment by Darren Cox on 18 January 2023, 11:07 https://devapps.diality.us/cru/HD-DEN-14549-1#c16092 Treatment mode check is not done in Voltages.c, so ALARM_ID_HD_AC_POWER_LOST will be set there in addition to ALARM_ID_HD_AC_POWER_LOST_IN_TREATMENT here. Is this the expected behavior? Reply by Sean Nash on 18 January 2023, 11:47 > Good catch. Updated Voltages.c to behave same as Battery.c > (trigger the correction alarm depending on whether in a > treatment mode). Reply by Darren Cox on 18 January 2023, 11:53 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Modes/PreTreatmentRecirc.c Revision Comment by wbracken on 22 January 2023, 21:04 https://devapps.diality.us/cru/HD-DEN-14549-1#c16211 Comments line up but the values don't? Reply by Sean Nash on 27 January 2023, 13:37 > Fixed. Reply by wbracken on 31 January 2023, 11:08 > RESOLVED IN CODE WALKTHROUGH Revision Comment by wbracken on 22 January 2023, 21:04 https://devapps.diality.us/cru/HD-DEN-14549-1#c16212 Alignment Reply by Sean Nash on 27 January 2023, 11:45 > Not required. Reply by wbracken on 31 January 2023, 10:58 > RESOLVED IN CODE WALKTHROUGH --- ID: HD-DEN-14549-1 https://devapps.diality.us/cru/HD-DEN-14549-1 Title: HD-DEN-14549_System Fault After Resuming Heparin Then Starting Saline Bolus During Treatment Statement of Objectives: State: Closed Summary: Author: Sean Nash Moderator: Sean Nash Reviewers: (4 active, 2 completed*) wbracken (*) Darren Cox (*) Michael Garthwaite Dara Navaei jtaylor Steve Jarpe