This is a list of all comments for HD-DEN-14763-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/ModeStandby.c
Revision Comment by Sean Nash on 20 March 2023, 08:58 
https://devapps.diality.us/cru/HD-DEN-14763-1#c16871

  Update comment.

  Reply by Dara Navaei on 20 March 2023, 09:37
  > Done

    Reply by Sean Nash on 20 March 2023, 09:50
    > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: firmware/App/Services/SystemCommMessages.c
Revision Comment by Sean Nash on 20 March 2023, 09:03 
https://devapps.diality.us/cru/HD-DEN-14763-1#c16872

  size was right.

  Reply by Dara Navaei on 20 March 2023, 09:36
  > Reverted back. Thanks for catching it.

    Reply by Sean Nash on 20 March 2023, 09:50
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 20 March 2023, 09:07 
https://devapps.diality.us/cru/HD-DEN-14763-1#c16873

  Since these are Dialin commands (0x8... msg IDs), we should
  require login before calling hard stop functions.

  Reply by Dara Navaei on 20 March 2023, 09:44
  > Done

    Reply by Sean Nash on 20 March 2023, 09:51
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-14763-1 https://devapps.diality.us/cru/HD-DEN-14763-1

Title: HD-DEN-14763_DG HD Dev HD DG Dvt Update Part 10
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (5 active, 1 completed*)
     Sean Nash   (*)
     Michael Garthwaite
     wbracken
     Darren Cox
     jtaylor
     Steve Jarpe