This is a list of all comments for HD-DEN-14830-2.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/DGInterface.c
Revision Comment by Sean Nash on 27 February 2023, 11:29 
https://devapps.diality.us/cru/HD-DEN-14830-2#c16532

  I thought the non-safety temp alarms had a large persistence.
  Now they have none?

  Reply by Michael Garthwaite on 27 February 2023, 11:35
  > PRS (Ex: PRS 377) no longer has it as of 1/05. SRS (Ex: SRSHD
  > 901) does. which one should be enforced?

    Reply by Sean Nash on 27 February 2023, 11:39
    > Let's review PRS req together.  Seems like we have
    > conflicting alarm properties in place that don't make sense
    > to me.  Let's figure out what behavior Systems team is
    > looking for here and then decide what
    > properties/persistence should be set.

      Reply by Michael Garthwaite on 07 March 2023, 16:42
      > Fixed. Thanks!

        Reply by Sean Nash on 08 March 2023, 21:12
        > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 08 March 2023, 21:05 
https://devapps.diality.us/cru/HD-DEN-14830-2#c16659

  Remove blank line.

  Reply by Sean Nash on 07 April 2023, 13:29
  > RESOLVED in CODE WALKTHROUGH.

----------------------------------------
File: AlarmDefs.h
Revision Comment by wbracken on 05 April 2023, 13:44 
https://devapps.diality.us/cru/HD-DEN-14830-2#c17049

  Comment alignment.

  Reply by Michael Garthwaite on 07 April 2023, 11:48
  > Fixed. Thanks!

    Reply by wbracken on 07 April 2023, 13:32
    > RESOLVED IN CODE WALKTHROUGH

Revision Comment by Sean Nash on 27 February 2023, 11:22 
https://devapps.diality.us/cru/HD-DEN-14830-2#c16531

  If you clear immediately, it will let you resume/clear alarm
  immediately (before temp comes back into range), but then alarm
  will re-trigger immediately (because temp is still out of
  range).

  Reply by Michael Garthwaite on 07 March 2023, 16:54
  > Fixed?

    Reply by Sean Nash on 08 March 2023, 21:15
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 06 March 2023, 09:58 
https://devapps.diality.us/cru/HD-DEN-14830-2#c16586

  Why alarm if above low temp?  I think >42 or > tgt+4 should be
  two ways to get same non-safety high temp alarm.
  And I think <33 or < tgt-4 should be two ways to get same
  non-safety low temp alarm.
  Did Systems want to separate these?  My understanding was not
  to separate.

  Reply by Michael Garthwaite on 07 March 2023, 16:46
  > To answer this and comment below:
  > 
  > above_high_safety_range = temp > 46
  > above_low_safety_range = temp > 42
  > above_target_temp = target + 4
  > below_target_temp = target - 4
  > below_low_safety_range = temp < 33
  > 
  > I did not see any specification regarding to separate or not
  > to separate. Original functionality had separate triggers.
  > Respective PRS's state OR between the two triggers. 
  > I think it would be clear to for us in terms of debugging to
  > see which alarm is triggered since on the low side, temp - 4
  > would be lower than 33, (31).
  > 
  > Wording may be unclear. Im up for suggestions to help clarify
  > the alarm differences.

    Reply by Sean Nash on 07 April 2023, 13:30
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-14830-2 https://devapps.diality.us/cru/HD-DEN-14830-2

Title: HD-DEN-14830_Incorrect Dialysate Temperature Alarm Triggered
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (3 active, 3 completed*)
     Sean Nash   (*)
     wbracken   (*)
     Dara Navaei   (*)
     Darren Cox
     jtaylor
     Steve Jarpe