This is a list of all comments for HD-DEN-14906-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Modes/Dialysis.c Revision Comment by Sean Nash on 14 March 2023, 16:04 https://devapps.diality.us/cru/HD-DEN-14906-1#c16743 Comment doesn't match const name. This is essentially 5 hours. Why are we repriming after 5 hours? We have a #define below that seems to be better suited for the reprime 5 minutes before end of treatment. So why do we need this const? Reply by Steve Jarpe on 15 March 2023, 09:57 > Removed and replaced with a different approach (flag) Reply by Sean Nash on 15 March 2023, 11:43 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 14 March 2023, 16:03 https://devapps.diality.us/cru/HD-DEN-14906-1#c16742 I think the rest of these are durations, not intervals. Reply by Steve Jarpe on 15 March 2023, 09:56 > Done Reply by Sean Nash on 15 March 2023, 11:16 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 14 March 2023, 16:08 https://devapps.diality.us/cru/HD-DEN-14906-1#c16745 Maybe state durations instead of function delays. Reply by Steve Jarpe on 15 March 2023, 10:34 > Done. Reply by Sean Nash on 15 March 2023, 11:42 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 14 March 2023, 16:27 https://devapps.diality.us/cru/HD-DEN-14906-1#c16746 Do we need something similar to this for dialyzer reprime? Reply by Steve Jarpe on 15 March 2023, 10:52 > Need more info. Reply by Sean Nash on 15 March 2023, 11:47 > Just wondering whether a reset function was needed for > reprime. Looks like you've added one. > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 15 March 2023, 08:56 https://devapps.diality.us/cru/HD-DEN-14906-1#c16760 Need to reject a saline bolus request if re-prime is in progress. Reply by Steve Jarpe on 15 March 2023, 10:49 > Done Reply by Sean Nash on 15 March 2023, 11:19 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 14 March 2023, 16:48 https://devapps.diality.us/cru/HD-DEN-14906-1#c16748 This check to see if it's time to do reprime should be moved to the handler for dialysis: ultrafiltration state (function just below this one) - because we would not want to start a reprime in the middle of a saline bolus or a reprime and because we should only be incrementing the timer counter during actual treatment (when treatment time is not paused). Reply by Steve Jarpe on 15 March 2023, 09:58 > Done Reply by Sean Nash on 15 March 2023, 11:39 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 14 March 2023, 16:40 https://devapps.diality.us/cru/HD-DEN-14906-1#c16747 I don't understand what the timer > 5 hours is doing here. Timer counter should never get bigger than 30 minutes (resets to zero after reprime completes), so would never get to 5 hours anyway. I think we just do reprime if 30 min interval OR 5 minutes remaining in treatment. And once we do the reprime for 5 min before end of treatment, we need some way to not do it again (i.e. if we just say time remaining <= 5 minutes, we will keep doing reprimes over and over again for the last 5 minutes). Reply by Steve Jarpe on 14 March 2023, 17:27 > The timer should have been 5 minutes, my mistake. The purpose > is to prevent repeated triggering of the reprime after the 5 > minute before treatment reprime is done, as you pointed out. > If I change the 5 hours to 5 minutes, is that OK? Reply by Sean Nash on 14 March 2023, 17:30 > I suppose that could work. Reply by Steve Jarpe on 15 March 2023, 09:58 > This was done with a flag instead. Reply by Sean Nash on 15 March 2023, 11:20 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 14 March 2023, 17:00 https://devapps.diality.us/cru/HD-DEN-14906-1#c16750 Need to command dialysate pumps to zero flow rate so they start ramping down. Reply by Steve Jarpe on 15 March 2023, 09:59 > Created an init function that initializes variables and sets > the pump flow rates to 0. Reply by Sean Nash on 15 March 2023, 11:39 > RESOLVED in CODE WALKTHROUGH. Revision Comment by wbracken on 15 March 2023, 13:54 https://devapps.diality.us/cru/HD-DEN-14906-1#c16799 Space before ")" Reply by Sean Nash on 16 March 2023, 08:42 > Fixed. Reply by wbracken on 16 March 2023, 12:14 > RESOLVED IN CODE WALKTHROUGH Revision Comment by Sean Nash on 14 March 2023, 16:58 https://devapps.diality.us/cru/HD-DEN-14906-1#c16749 Might want to include DialyzerRePrime in these state function names for clarity (similar to saline bolus state function names). Reply by Steve Jarpe on 15 March 2023, 09:11 > Done Reply by Sean Nash on 15 March 2023, 11:22 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 15 March 2023, 08:46 https://devapps.diality.us/cru/HD-DEN-14906-1#c16759 Per our re-prime slide deck, we wanted to change minimum ultrafiltration volume from zero to X mL. X = treatment duration (in hrs) x 100 mL. I think changes are in order in ModeTreatmentParams.c and perhaps elsewhere to implement that change. Also, in Reservoirs.c, we will want to prevent dialysate use from being counted while in re-prime states. Also, there were some alarms we wanted to exempt while performing re-prime. Let me know if you'd like me to handle any of these parts of the implementation. Reply by Steve Jarpe on 15 March 2023, 09:31 > I am unfamiliar with all of those parts of the firmware, so > it would probably be more efficient for you to do them. Reply by Sean Nash on 15 March 2023, 11:48 > Will do. Reply by Sean Nash on 16 March 2023, 08:41 > Handled minimum UF rate in another branch. Implemented > the rest here. > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 14 March 2023, 17:04 https://devapps.diality.us/cru/HD-DEN-14906-1#c16752 Generally don't like static variables declared locally in function. Initialization is tricky. Would move to module level scope if needed at all. I don't think it is needed if you command pumps to zero before you get to this state. Reply by Steve Jarpe on 15 March 2023, 10:00 > Removed Reply by Sean Nash on 15 March 2023, 11:37 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 14 March 2023, 17:02 https://devapps.diality.us/cru/HD-DEN-14906-1#c16751 Timer counter is reset in both cases so should be done once before or after the in progress condition is checked. Reply by Steve Jarpe on 15 March 2023, 10:00 > This was removed when the function was changed to solve other > problems. Reply by Sean Nash on 15 March 2023, 11:36 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 14 March 2023, 17:06 https://devapps.diality.us/cru/HD-DEN-14906-1#c16753 Recommend removing this else if and just commanding pumps to zero when transitioning to reprime state. Reply by Steve Jarpe on 15 March 2023, 10:01 > Done. Reply by Sean Nash on 15 March 2023, 11:36 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 14 March 2023, 17:26 https://devapps.diality.us/cru/HD-DEN-14906-1#c16754 Switching valves to dialyzer with DPo stopped initially will be a shock and temporarily send a lot of dialysate to the patient while DPo ramps up. So I think DPi should be hard stopped first and then start both DPi and DPo at fast purge rate together. Reply by Steve Jarpe on 15 March 2023, 10:21 > Done. Reply by Sean Nash on 15 March 2023, 11:27 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 14 March 2023, 17:35 https://devapps.diality.us/cru/HD-DEN-14906-1#c16757 I don't think we can just shift into reverse here. I think I had last SRS written in a way that we would go tack to the dialysate pumps off state to ramp down again before moving to reprime state. Reply by Steve Jarpe on 15 March 2023, 10:28 > Done Reply by Sean Nash on 15 March 2023, 11:33 > I think it would make more sense to set DPi rate to zero, > set re-prime in progress flag to FALSE, and set state to > dialysate pumps off which will then handle the ramp down > and transition to reprime state. Reply by Steve Jarpe on 15 March 2023, 11:53 > Done. Reply by Sean Nash on 15 March 2023, 15:25 > RESOLVED in CODE WALKTHROUGH. Revision Comment by wbracken on 15 March 2023, 14:01 https://devapps.diality.us/cru/HD-DEN-14906-1#c16800 Is dialysisState used in this function? Reply by Sean Nash on 15 March 2023, 15:24 > Doesn't look like it. Reply by Sean Nash on 16 March 2023, 08:49 > Fixed. Reply by wbracken on 16 March 2023, 12:14 > RESOLVED IN CODE WALKTHROUGH Revision Comment by Sean Nash on 14 March 2023, 17:41 https://devapps.diality.us/cru/HD-DEN-14906-1#c16758 If we get interrupted by an alarm, how will these vars get reset? Reply by Steve Jarpe on 15 March 2023, 10:32 > init function created for dialyzer reprime Reply by Sean Nash on 15 March 2023, 11:47 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: HDDefs.h Revision Comment by Sean Nash on 14 March 2023, 15:59 https://devapps.diality.us/cru/HD-DEN-14906-1#c16741 Let's add a build switch at top of HDCommon.h (where SIMULATE_UI is for example) to allow us to include or exclude this reprime feature from build (e.g. #define DIALYZER_REPRIME_ENABLED 1). Then, wherever you have dialyzer reprime code, surround with #ifdef DIALYZER_REPRIME_ENABLED and #endif. Reply by Steve Jarpe on 15 March 2023, 11:06 > Done. Reply by Sean Nash on 15 March 2023, 11:15 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/HDCommon.h Revision Comment by Sean Nash on 15 March 2023, 11:12 https://devapps.diality.us/cru/HD-DEN-14906-1#c16778 Comment should say with, not without. Reply by Steve Jarpe on 15 March 2023, 11:58 > Done Reply by Sean Nash on 15 March 2023, 15:22 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Controllers/PresOccl.c Revision Comment by wbracken on 23 March 2023, 21:52 https://devapps.diality.us/cru/HD-DEN-14906-1#c16912 Should venPres < venLowLimit be done outside if statement? Reply by Sean Nash on 27 March 2023, 09:53 > Fixed. Reply by wbracken on 27 March 2023, 10:12 > RESOLVED IN CODE WALKTHROUGH --- ID: HD-DEN-14906-1 https://devapps.diality.us/cru/HD-DEN-14906-1 Title: HD-DEN-14906_Dialyzer DE Prime Statement of Objectives: State: Closed Summary: Author: Steve Jarpe Moderator: Steve Jarpe Reviewers: (2 active, 4 completed*) Sean Nash (*) Michael Garthwaite (*) wbracken (*) Dara Navaei (*) Darren Cox jtaylor