This is a list of all comments for HD-DEN-14999-2.

Review Summary: No summary


----------------------------------------
File: firmware/App/Services/SystemComm.c
Revision Comment by wbracken on 29 March 2023, 12:22 
https://devapps.diality.us/cru/HD-DEN-14999-2#c16980

  Add timeOfLastUICheckin and uiDidCommunicate.

  Reply by Sean Nash on 30 March 2023, 09:38
  > Fixed.

    Reply by wbracken on 30 March 2023, 09:47
    > RESOLVED IN CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Services/AlarmMgmt.c
Revision Comment by wbracken on 26 March 2023, 22:27 
https://devapps.diality.us/cru/HD-DEN-14999-2#c16913

  What's the significance of changing to U32?  Is this being used
  as a timer?

  Reply by Sean Nash on 27 March 2023, 08:57
  > Changing from U32 to S32.  It is a relative ms timer (so
  > wouldn't be negative), but I needed to initialize this to
  > something less than zero so that alarm ranking logic will be
  > forced to rank a brand new alarm (triggered 0 ms ago).

    Reply by wbracken on 27 March 2023, 11:07
    > RESOLVED IN CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Modes/Rinseback.c
Revision Comment by wbracken on 28 March 2023, 14:22 
https://devapps.diality.us/cru/HD-DEN-14999-2#c16927

  Does the new code result in one less TRUE comparison?  Can
  rinsebackTimerCtr ever be greater than
  RINSEBACK_DONE_WARNING_TIME?

  Reply by Sean Nash on 30 March 2023, 09:39
  > Warning (13 min) removed since no longer alarming at 15 min.

    Reply by wbracken on 30 March 2023, 09:44
    > RESOLVED IN CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Services/SystemCommMessages.c
Revision Comment by Michael Garthwaite on 30 March 2023, 10:18 
https://devapps.diality.us/cru/HD-DEN-14999-2#c16995

  What is the other flavor of UI check in message. If it is a
  different size, shouldn't it be its own separate message?

  Reply by Sean Nash on 30 March 2023, 11:31
  > I don't know.  I believe check in msg should have no payload,
  > but it usually does have a u32 of unknown purpose.  I have
  > found that the very first check-in after power up has no
  > payload according to candump and this was causing alarm 46.
  > Until UI sorts this out, I am not going to check payload.

    Reply by Michael Garthwaite on 30 March 2023, 12:22
    > RESOLVED IN CODE WALKTHROUGH.


---

ID: HD-DEN-14999-2 https://devapps.diality.us/cru/HD-DEN-14999-2

Title: HD-DEN-14999_Alarm Table Updates
Statement of Objectives:


State: Closed

Summary: 

Author: Sean Nash
Moderator: Sean Nash
Reviewers: (4 active, 2 completed*)
     Dara Navaei   (*)
     jtaylor   (*)
     Michael Garthwaite
     wbracken
     Darren Cox
     Steve Jarpe