This is a list of all comments for HD-DEN-15049-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/Voltages.c
Revision Comment by Sean Nash on 13 April 2023, 13:14 
https://devapps.diality.us/cru/HD-DEN-15049-1#c17092

  No longer needed?

  Reply by wbracken on 13 April 2023, 13:48
  > Removed

    Reply by Sean Nash on 13 April 2023, 13:58
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 13 April 2023, 13:10 
https://devapps.diality.us/cru/HD-DEN-15049-1#c17088

  We want to use CPLD for this.  Keep this line, remove line
  below where initialized to FALSE.

  Reply by wbracken on 13 April 2023, 13:53
  > Corrected

    Reply by Sean Nash on 13 April 2023, 13:58
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 13 April 2023, 13:12 
https://devapps.diality.us/cru/HD-DEN-15049-1#c17090

  Remove this method of determine whether AC power has been lost.
  CPLD function above is what we want.

  Reply by wbracken on 13 April 2023, 13:52
  > Corrected

    Reply by Sean Nash on 13 April 2023, 13:57
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 13 April 2023, 13:16 
https://devapps.diality.us/cru/HD-DEN-15049-1#c17093

  I think we can fit this whole comment on the 1 line.  Bring
  closer to break; if need more room.

  Reply by wbracken on 13 April 2023, 13:51
  > Corrected

    Reply by Sean Nash on 13 April 2023, 13:57
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 13 April 2023, 13:20 
https://devapps.diality.us/cru/HD-DEN-15049-1#c17094

  I think we can just say "if ( TRUE == hasPowerBeenLost )" here.
  Zero trigger persistence time now that CPLD is making
  determination.

  Reply by wbracken on 13 April 2023, 13:51
  > Corrected

    Reply by Sean Nash on 13 April 2023, 13:57
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Darren Cox on 13 April 2023, 14:17 
https://devapps.diality.us/cru/HD-DEN-15049-1#c17112

  Are these alarms intentionally commented?  Should they be
  activated or removed?

  Reply by wbracken on 13 April 2023, 14:22
  > They should remain.  Will be uncommented when all DVT units
  > have updated hardware.

    Reply by Dara Navaei on 19 October 2023, 09:04
    > RESOLVED in CODE WALKTHROUGH

----------------------------------------
File: firmware/App/Controllers/Voltages.h
Revision Comment by Sean Nash on 12 April 2023, 11:05 
https://devapps.diality.us/cru/HD-DEN-15049-1#c17077

  Comments appear to be swapped.

  Reply by wbracken on 12 April 2023, 11:24
  > Comment is identical to the DG implementation.

    Reply by Sean Nash on 13 April 2023, 11:46
    > Still wrong though.

  Reply by wbracken on 13 April 2023, 13:11
  > Corrected

    Reply by Sean Nash on 13 April 2023, 13:13
    > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-15049-1 https://devapps.diality.us/cru/HD-DEN-15049-1

Title: HD-DEN-15049_FW HD Voltage Not Trigger Alarm 76 When Voltage Out OF Range IN Line
Statement of Objectives:


State: Closed

Summary: 

Author: wbracken
Moderator: wbracken
Reviewers: (4 active, 2 completed*)
     Sean Nash   (*)
     jtaylor   (*)
     Michael Garthwaite
     Dara Navaei
     Darren Cox
     Steve Jarpe