This is a list of all comments for HD-DEN-15196-2. Review Summary: No summary ---------------------------------------- File: firmware/App/Modes/ConsumableSelfTest.c Revision Comment by Sean Nash on 14 May 2023, 17:30 https://devapps.diality.us/cru/HD-DEN-15196-2#c17505 Do we need to call this function on transition to consumables self-test so that op modes will get initial state? (Question applies throughout this code branch) Reply by Michael Garthwaite on 15 May 2023, 10:32 > yes we should. fixed to have these calls in their respective > transition functions. Reply by Michael Garthwaite on 16 May 2023, 14:03 > Fixed. Thanks! Reply by Sean Nash on 16 May 2023, 15:44 > RESOLVED in CODE WALKTHROUGH. Revision Comment by wbracken on 15 May 2023, 11:01 https://devapps.diality.us/cru/HD-DEN-15196-2#c17556 Should the argument for setCurrentSubState be a CONSUMABLE_SELF_TEST_STATE_T? Other calls don't cast to U32. Reply by Michael Garthwaite on 16 May 2023, 14:03 > converted all calls to setCurrentSubState to have a casted > U32. Thanks! Reply by wbracken on 16 May 2023, 14:35 > RESOLVED IN CODE WALKTHROUGH ---------------------------------------- File: firmware/App/Modes/Dialysis.c Revision Comment by Sean Nash on 14 May 2023, 17:32 https://devapps.diality.us/cru/HD-DEN-15196-2#c17506 In consumable self-test, you removed the old send substate change event. Why keep this one? Reply by Michael Garthwaite on 15 May 2023, 09:56 > I want to keep the old sub state change events for dialin > compatibility. I believe other tests use the sub state change > event Reply by Sean Nash on 15 May 2023, 10:38 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 14 May 2023, 17:39 https://devapps.diality.us/cru/HD-DEN-15196-2#c17513 This is a 4th level state. Currently not supported I think. Reply by Michael Garthwaite on 15 May 2023, 10:33 > Fixed. Thanks! Reply by Sean Nash on 15 May 2023, 10:39 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 14 May 2023, 17:40 https://devapps.diality.us/cru/HD-DEN-15196-2#c17514 This is a 4th level state. Currently not supported I think. Reply by Michael Garthwaite on 15 May 2023, 10:33 > Fixed. Thanks! Reply by Sean Nash on 15 May 2023, 10:39 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModePostTreat.c Revision Comment by Sean Nash on 14 May 2023, 17:43 https://devapps.diality.us/cru/HD-DEN-15196-2#c17515 Post treatment starts in drain reservoirs submode which does have a substate. Once we leave drain reservoirs submode, then we should call this function with no substate for remainder of post treatment submodes. Reply by Michael Garthwaite on 15 May 2023, 10:33 > Fixed. Thanks! Reply by Sean Nash on 15 May 2023, 10:41 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModePreTreat.c Revision Comment by Sean Nash on 14 May 2023, 18:28 https://devapps.diality.us/cru/HD-DEN-15196-2#c17516 Not many submodes in pre-tx that don't have substates - maybe cartridge install. Should call this when entering a submode with no substates. Reply by Michael Garthwaite on 15 May 2023, 10:33 > Fixed. Thanks! Reply by Sean Nash on 15 May 2023, 10:42 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeTreatment.c Revision Comment by Sean Nash on 14 May 2023, 18:29 https://devapps.diality.us/cru/HD-DEN-15196-2#c17517 Is there any submode of treatment mode that does not have substates? Reply by Michael Garthwaite on 15 May 2023, 10:07 > Blood prime and treatment start sub modes dont have a > substate. The call here will cover the treatment start sub > mode. Blood prime will be covered in the transition to blood > prime Reply by Sean Nash on 15 May 2023, 10:43 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/ModeTreatmentParams.c Revision Comment by Sean Nash on 14 May 2023, 18:30 https://devapps.diality.us/cru/HD-DEN-15196-2#c17518 Should this be in transition function? Reply by Michael Garthwaite on 15 May 2023, 10:30 > Fixed. Thanks! Reply by Sean Nash on 15 May 2023, 10:44 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/OperationModes.c Revision Comment by Sean Nash on 14 May 2023, 17:39 https://devapps.diality.us/cru/HD-DEN-15196-2#c17512 Not clear to me which of the older events are still being supported. What's the plan? Reply by Michael Garthwaite on 15 May 2023, 10:13 > going to keep the old style of events for now so we dont > break previous V&V testing. Reply by Michael Garthwaite on 15 May 2023, 10:33 > Fixed. Thanks! Reply by Sean Nash on 15 May 2023, 10:50 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 14 May 2023, 17:36 https://devapps.diality.us/cru/HD-DEN-15196-2#c17508 Missing function header. Reply by Michael Garthwaite on 15 May 2023, 10:29 > Fixed. Thanks! Reply by Sean Nash on 15 May 2023, 10:58 > RESOLVED in CODE WALKTHROUGH. Revision Comment by wbracken on 12 May 2023, 14:32 https://devapps.diality.us/cru/HD-DEN-15196-2#c17428 Missing function header Reply by Michael Garthwaite on 15 May 2023, 10:29 > Fixed. Thanks! Reply by wbracken on 15 May 2023, 11:24 > RESOLVED IN CODE WALKTHROUGH Revision Comment by Sean Nash on 14 May 2023, 17:36 https://devapps.diality.us/cru/HD-DEN-15196-2#c17509 should be "void sendOperationStatusEvent( void )" Reply by Michael Garthwaite on 15 May 2023, 10:29 > Fixed. Thanks! Reply by Sean Nash on 15 May 2023, 11:17 > I don't see fix. Reply by Michael Garthwaite on 16 May 2023, 14:02 > My mistake. fixed! Reply by Sean Nash on 16 May 2023, 15:46 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 14 May 2023, 17:34 https://devapps.diality.us/cru/HD-DEN-15196-2#c17507 Remove blank line. Reply by Michael Garthwaite on 15 May 2023, 10:29 > Fixed. Thanks! Reply by Sean Nash on 15 May 2023, 11:18 > I don't see fix. Reply by Michael Garthwaite on 16 May 2023, 14:02 > My mistake. fixed! Reply by Sean Nash on 16 May 2023, 15:47 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 14 May 2023, 17:36 https://devapps.diality.us/cru/HD-DEN-15196-2#c17510 What is d2? Reply by Michael Garthwaite on 15 May 2023, 10:29 > unneeded code from other event usage. Fixed. Thanks! Reply by Sean Nash on 15 May 2023, 11:18 > RESOLVED in CODE WALKTHROUGH. Revision Comment by Sean Nash on 14 May 2023, 17:38 https://devapps.diality.us/cru/HD-DEN-15196-2#c17511 Remove extra "}". Should be 2 blank lines above test support banner. Reply by Michael Garthwaite on 15 May 2023, 10:29 > Fixed. Thanks! Reply by Sean Nash on 15 May 2023, 11:18 > RESOLVED in CODE WALKTHROUGH. ---------------------------------------- File: firmware/App/Modes/SelfTests.c Revision Comment by Sean Nash on 14 May 2023, 18:32 https://devapps.diality.us/cru/HD-DEN-15196-2#c17519 This is a 4th level state - not currently supported I think. Reply by Michael Garthwaite on 15 May 2023, 10:32 > Fixed. Thanks! Reply by Sean Nash on 15 May 2023, 11:19 > RESOLVED in CODE WALKTHROUGH. --- ID: HD-DEN-15196-2 https://devapps.diality.us/cru/HD-DEN-15196-2 Title: HD-DEN-15196_DIAL-251 Statement of Objectives: State: Closed Summary: Author: Michael Garthwaite Moderator: Michael Garthwaite Reviewers: (3 active, 3 completed*) Sean Nash (*) wbracken (*) jtaylor (*) Dara Navaei Darren Cox Steve Jarpe