This is a list of all comments for HD-DEN-15229-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/ModePreTreat.c
Revision Comment by Sean Nash on 14 May 2023, 15:17 
https://devapps.diality.us/cru/HD-DEN-15229-1#c17462

  I think we still want to get credit for opening the door in
  this state - and so need to be okay with door opening (not
  required to be closed) and so probably should be calling your
  door handler here.

  Reply by Darren Cox on 15 May 2023, 15:39
  > Updated to do this.  To me it seems counter intuitive.  If
  > the user opens door when UF or BP screen is showing, then
  > Open door screen come up, user opens door and gets alarm.  If
  > they hit next, it shows flip dialyzer screen but still alarms
  > if door opened.

    Reply by Sean Nash on 15 May 2023, 16:13
    > We are (I think now) allowing door open in first 2 states
    > (UF and invert dialyzer), so should not be getting door
    > open alarm when UI is prompting user to invert dialyzer.
    > When we get to 3rd state (where we start requiring door to
    > be closed), we are looking for user to connect patient and
    > confirm.  UI should be following along with our states and
    > showing appropriate screens.
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 12 May 2023, 10:25 
https://devapps.diality.us/cru/HD-DEN-15229-1#c17388

  Should we have an else to turn pump and heater back on when
  door is closed?

  Reply by Darren Cox on 12 May 2023, 10:51
  > I did not want to have the pump turning on/off if opened more
  > than once.  Stop while the user performs the action, then
  > turn on when they are done. Maybe wait to turn on until user
  > confirm.

    Reply by Sean Nash on 12 May 2023, 11:37
    > With that approach, we are likely to have pump/heater off
    > for some time which will allow the dialysate to cool and
    > perhaps cause a temperature alarm when we do start
    > treatment.
    > I think we should have the pump/heater on when door is
    > closed in patient connect states.

      Reply by Sean Nash on 12 May 2023, 12:49
      > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 12 May 2023, 10:23 
https://devapps.diality.us/cru/HD-DEN-15229-1#c17387

  Since pump is going to be on and next state is not calling your
  door check function, should we call doorClosedRequired( TRUE,
  TRUE ) here?  Or next state could call your door check function
  to handle it.

  Reply by Darren Cox on 12 May 2023, 10:55
  > it is done in the next state - user confirm.  May be a better
  > idea to move this pump & heater on to that state after user
  > confirm.

    Reply by Sean Nash on 12 May 2023, 11:16
    > Next state only requires door closed after confirm (when
    > state is done).  In meantime, door can be opened while pump
    > is on and no alarm will occur and pump stays on I would
    > think.

      Reply by Sean Nash on 12 May 2023, 12:52
      > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 14 May 2023, 15:21 
https://devapps.diality.us/cru/HD-DEN-15229-1#c17463

  Once we leave this state, we've done the door open/close that
  we were looking for - so should start requiring door to be
  closed from this point forward.

  Reply by Darren Cox on 15 May 2023, 14:39
  > Done.  Reset door flag also.

    Reply by Sean Nash on 15 May 2023, 16:06
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 14 May 2023, 15:25 
https://devapps.diality.us/cru/HD-DEN-15229-1#c17464

  Not sure we need this in this state if we require door to be
  closed in this state.

  Reply by Darren Cox on 15 May 2023, 14:42
  > Removed

    Reply by Sean Nash on 15 May 2023, 16:05
    > Doesn't look removed.  I'm talking about the call to
    > handlePatientConnectionDoorOpened().  Do we need this now
    > that door closed is required (as set in prior state)?

      Reply by Darren Cox on 15 May 2023, 16:40
      > Correct, no longer required.  Removed.

        Reply by Sean Nash on 16 May 2023, 08:56
        > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 14 May 2023, 15:26 
https://devapps.diality.us/cru/HD-DEN-15229-1#c17465

  Not needed if we do this in prior state.

  Reply by Darren Cox on 15 May 2023, 14:40
  > Removed

    Reply by Sean Nash on 15 May 2023, 15:59
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 14 May 2023, 15:30 
https://devapps.diality.us/cru/HD-DEN-15229-1#c17467

  By this point, we've already accepted the confirm from user so
  we need to move on to next state even if door is open - not
  sure this could even happen if we require door closed for
  entirety of this state.

  Reply by Darren Cox on 15 May 2023, 14:41
  > Removed

    Reply by Sean Nash on 15 May 2023, 15:59
    > RESOLVED in CODE WALKTHROUGH.

Revision Comment by Sean Nash on 14 May 2023, 15:31 
https://devapps.diality.us/cru/HD-DEN-15229-1#c17468

  Should probably set confirm flag to FALSE here even though it
  probably gets reset at some point before next treatment.

  Reply by Darren Cox on 15 May 2023, 14:40
  > Reset flag in previous state.

    Reply by Sean Nash on 15 May 2023, 16:01
    > Doesn't make sense to reset in previous state.  You're
    > resetting door opened flag there.  I'm talking about
    > patient connect confirm flag used in if statement above.

      Reply by Darren Cox on 15 May 2023, 16:35
      > Reset proper flag.

        Reply by Sean Nash on 16 May 2023, 08:55
        > RESOLVED in CODE WALKTHROUGH.


---

ID: HD-DEN-15229-1 https://devapps.diality.us/cru/HD-DEN-15229-1

Title: HD-DEN-15229_FW Dpi Pump ON During Inverted Dialyzer
Statement of Objectives:


State: Closed

Summary: 

Author: Darren Cox
Moderator: Darren Cox
Reviewers: (4 active, 2 completed*)
     Sean Nash   (*)
     wbracken   (*)
     Michael Garthwaite
     Dara Navaei
     jtaylor
     Steve Jarpe